buffer: use v8::TypedArray::kMaxLength as buffer::kMaxLength#19738
Closed
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Closed
buffer: use v8::TypedArray::kMaxLength as buffer::kMaxLength#19738joyeecheung wants to merge 1 commit intonodejs:masterfrom
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
buffer
Member
Author
|
cc @bnoordhuis |
Member
Author
4 tasks
jasnell
approved these changes
Apr 2, 2018
addaleax
approved these changes
Apr 2, 2018
cjihrig
approved these changes
Apr 2, 2018
Member
Author
|
Landed in 30fe55e, thanks! |
joyeecheung
added a commit
that referenced
this pull request
Apr 4, 2018
This was added in v8 6.2, looks like a safe replacement for our own buffer::kMaxLength. PR-URL: #19738 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 4, 2018
This was added in v8 6.2, looks like a safe replacement for our own buffer::kMaxLength. PR-URL: #19738 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added in v8 6.2 by v8/v8@19fee8b, looks like a safe replacement for our own buffer::kMaxLength
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes