test: remove third argument from call to assert.strictEqual()#19659
test: remove third argument from call to assert.strictEqual()#19659ForrestWeiswolf wants to merge 1 commit intonodejs:masterfrom
Conversation
Remove the message argument from call to assert.strictEqual so that the AssertionError will report the value of er.code, and add a comment with the message.
|
(Could make the |
Trott
added
the
author ready
|
It says 'node-test-commit — tests failed'. I'm having trouble reading the details of that; is there something I need to do at this point? |
|
@ForrestWeiswolf TL/DR: Nothing to do, it's unrelated, I'll re-run the one host that failed. Clicking through the results, there's only one failure, and it involves Looking more closely, it is an issue we see a fair amount lately where a test process seems to crash in CI but no stack trace is provided. (@BridgeAR, another one! Is there an open issue I can link these too? I did a quick search but didn't find one.) https://ci.nodejs.org/job/node-test-commit-plinux/16401/nodes=ppcle-ubuntu1404/console not ok 1036 parallel/test-inspector-no-crash-ws-after-bindings
---
duration_ms: 1.318
severity: fail
stack: |-
[err] Debugger listening on ws://127.0.0.1:57972/e7574d26-00ef-4ec7-84b5-706de0257bd2
[err]
[err] For help see https://nodejs.org/en/docs/inspector
[err]
[err] Can connect now!
[err]
[test] Checking upgrade is not possible
[test] Testing /json/list
... |
|
Re-running |
Remove the message argument from call to assert.strictEqual so that the AssertionError will report the value of er.code, and add a comment with the message. PR-URL: #19659 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in 14310b5 Congratulations @ForrestWeiswolf for your first commit in Node.js core! 🎉🎉🎉 |
Remove the message argument from call to assert.strictEqual so that the AssertionError will report the value of er.code, and add a comment with the message. PR-URL: #19659 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Remove the message argument from call to assert.strictEqual so that the AssertionError will report the value of er.code, and add a comment with the message. PR-URL: #19659 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
8 participants
Remove the message argument from call to assert.strictEqual so
that the AssertionError will report the value of er.code, and add
a comment with the message.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes