Closed
Conversation
nodejs-github-bot
added
i18n-api
addaleax
approved these changes
Mar 26, 2018
richardlau
approved these changes
Mar 27, 2018
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
LGTM.
The commit message be "turn on" rather than "turn in", or maybe just "use".
danbev
approved these changes
Mar 27, 2018
TimothyGu
approved these changes
Mar 27, 2018
srl295
changed the title
Member
Author
|
@richardlau “turn in” is a typo. |
This was referenced Mar 28, 2018
srl295
added a commit
that referenced
this pull request
Mar 28, 2018
- node and v8 did not call into std::string previously, so that access was shut off. - this fixes compilation for ICU 58.2 (backlevel) but may be expressed in other versions also. Fixes: #19151 PR-URL: #19624 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
srl295
force-pushed
the
icu-fix-stdstring
branch
from
f632c66 to
4de7821
Compare
Member
Author
|
@richardlau oops, i had fixed the commit title but didn't do it properly before push (but after local test!) |
targos
pushed a commit
that referenced
this pull request
Apr 2, 2018
- node and v8 did not call into std::string previously, so that access was shut off. - this fixes compilation for ICU 58.2 (backlevel) but may be expressed in other versions also. Fixes: #19151 PR-URL: #19624 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #19151
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes