doc: remove use of "random port" regarding dgram send#19620
Closed
tlhunter wants to merge 1 commit intonodejs:masterfrom
Closed
doc: remove use of "random port" regarding dgram send#19620tlhunter wants to merge 1 commit intonodejs:masterfrom
tlhunter wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
dgram
Trott
approved these changes
Mar 26, 2018
Member
Trott
added
the
author ready
vsemozhetbyt
added
the
fast-track
vsemozhetbyt
approved these changes
Mar 26, 2018
addaleax
approved these changes
Mar 26, 2018
Contributor
|
@tlhunter Can you check your local and GitHub settings: It seems the commit has not proper attribution. |
Contributor
Member
|
@vsemozhetbyt I would wait for confirmation from the author – the commit does have proper attribution as far as I can tell (name + email present and the email seems valid). That usually means that it’s easier for the author to add that email to github, if they do want that. |
Contributor
Author
|
@vsemozhetbyt @addaleax Whoops! That email should now be properly associated to my GH account. |
vsemozhetbyt
pushed a commit
that referenced
this pull request
Mar 27, 2018
PR-URL: #19620 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Contributor
|
Landed in cdfe47b Thank you! |
targos
pushed a commit
that referenced
this pull request
Mar 27, 2018
PR-URL: #19620 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 4, 2018
PR-URL: #19620 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This was referenced Dec 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
I removed the use of "random port" when referring to sending messages with dgram. Specifically in the examples the port isn't random, it is a hand-picked port which stays the same. Referring to it as a random port is confusing because in the listening methods the phrase "random port" has a special meaning, i.e. providing no port and letting the OS pick a random port.