repl: fix tab completion of inspector module#19505
Closed
targos wants to merge 1 commit intonodejs:masterfrom
Closed
repl: fix tab completion of inspector module#19505targos wants to merge 1 commit intonodejs:masterfrom
targos wants to merge 1 commit intonodejs:masterfrom
Conversation
Correctly check for the presence of the inspector module before adding it to the builtin libs list.
cjihrig
approved these changes
Mar 21, 2018
lpinca
approved these changes
Mar 21, 2018
hiroppy
approved these changes
Mar 21, 2018
Member
TimothyGu
approved these changes
Mar 22, 2018
jasnell
approved these changes
Mar 23, 2018
Member
Author
|
Rebuild plinux: https://ci.nodejs.org/job/node-test-commit-plinux/16264/ |
Member
Author
|
Landed in a6f3e8f |
targos
added a commit
that referenced
this pull request
Mar 23, 2018
Correctly check for the presence of the inspector module before adding it to the builtin libs list. PR-URL: #19505 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
added a commit
that referenced
this pull request
Mar 30, 2018
Correctly check for the presence of the inspector module before adding it to the builtin libs list. PR-URL: #19505 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctly check for the presence of the inspector module before adding
it to the builtin libs list.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes