tools: fix nits in tools/doc/preprocess.js#19473
Closed
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:tools-doc-preprocess
Closed
tools: fix nits in tools/doc/preprocess.js#19473vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom vsemozhetbyt:tools-doc-preprocess
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:tools-doc-preprocess
Conversation
nodejs-github-bot
added
doc
Contributor
Author
|
CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/277/ Let me know if we need full CI for this. |
vsemozhetbyt
added
refactor to ES6+
fast-track
tniessen
approved these changes
Mar 20, 2018
richardlau
approved these changes
Mar 21, 2018
Contributor
Author
|
Landed in 1d42b20 |
vsemozhetbyt
added a commit
that referenced
this pull request
Mar 21, 2018
PR-URL: #19473 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos
pushed a commit
that referenced
this pull request
Mar 24, 2018
PR-URL: #19473 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2018
PR-URL: #19473 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesES6 nits:
vars withlets..forEach()argument.RegExp nits:
[A-Za-z0-9-_]into[\w-].includeExprRegExp: there is no need to group in its case +includeExpris used only in.match()call that does not return capturing..match()with.test()in a boolean context.Logic nits:
.match()withgflag can only returnnullor non-empty array (it cannot return an array with0length) +incCountmay be changed only after this check.I've built the docs on Windows (using #19330) before and after these changes and both doc sets are identical +
test/doctool/test-make-doc.jsis OK.