Closed
Conversation
cjihrig
approved these changes
Mar 16, 2018
gireeshpunathil
approved these changes
Mar 16, 2018
vsemozhetbyt
approved these changes
Mar 16, 2018
richardlau
approved these changes
Mar 16, 2018
mmarchini
approved these changes
Mar 16, 2018
jasnell
approved these changes
Mar 16, 2018
watilde
approved these changes
Mar 16, 2018
Member
|
Looks like maybe this was done without someone actually doing the onboarding? I don't see @trivikr in the right GitHub team so they can't start CI and they can't land this PR. Anyone on @nodejs/tsc available to do an onboarding session with them? Maybe @mcollina as they nominated @trivikr? I'm not available until the middle of next week, but can do it after that if no one else steps up. |
richardlau
requested changes
Mar 17, 2018
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
Refs in commit message should be #19067
Member
|
I’m available all of next week. I’ll ping @trivikr via email. |
trivikr is nominated as node core collaborator for his work on http2 https://github.com/nodejs/node/commits?author=trivikr Refs: nodejs#19067
trivikr
force-pushed
the
add-trivikr-collab
branch
from
bf9c347 to
e6a3436
Compare
Member
Author
|
Thanks @richardlau for the catch! |
richardlau
approved these changes
Mar 17, 2018
thefourtheye
approved these changes
Mar 19, 2018
benjamingr
approved these changes
Mar 19, 2018
devsnek
approved these changes
Mar 19, 2018
Member
Author
Member
Author
|
Landed in 6a958d2 |
trivikr
added a commit
that referenced
this pull request
Mar 20, 2018
trivikr is nominated as node core collaborator for his work on http2 https://github.com/nodejs/node/commits?author=trivikr Refs: #19067 PR-URL: #19384 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Member
|
Welcome! |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 22, 2018
trivikr is nominated as node core collaborator for his work on http2 https://github.com/nodejs/node/commits?author=trivikr Refs: #19067 PR-URL: #19384 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2018
trivikr is nominated as node core collaborator for his work on http2 https://github.com/nodejs/node/commits?author=trivikr Refs: #19067 PR-URL: #19384 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trivikr is nominated as node core collaborator for his work on http2
https://github.com/nodejs/node/commits?author=trivikr
Refs: #19067
Checklist