Closed
Conversation
Add a `make jstest` target that runs tests written in JavaScript (excluding documentation tests which are run in `make test-doc`).
Member
|
Any reason not to add the same feature to |
Member
Author
|
@Trott Just me being bad at Windows batch scripts..? I could not find a |
lpinca
approved these changes
Mar 14, 2018
Contributor
|
There is |
Member
|
Wouldn't this make more sense as |
Member
Author
|
Mostly because |
Contributor
|
BTW, there is |
Member
Hmm okay. I'd probably still go with Existing list is: |
mmarchini
approved these changes
Mar 25, 2018
Member
Author
Member
Author
|
Landed in 2f8df6b, thanks! |
joyeecheung
added a commit
that referenced
this pull request
Apr 4, 2018
Add a `make jstest` target that runs tests written in JavaScript (excluding documentation tests which are run in `make test-doc`). PR-URL: #19324 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com>
targos
pushed a commit
that referenced
this pull request
Apr 4, 2018
Add a `make jstest` target that runs tests written in JavaScript (excluding documentation tests which are run in `make test-doc`). PR-URL: #19324 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
make jstesttarget that runs tests written in JavaScript(excluding documentation tests which are run in
make test-doc).Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes