[v9.x backport] doc: add new documentation rule#19189
Closed
estrada9166 wants to merge 1 commit intonodejs:v9.x-stagingfrom
estrada9166:backport-18726-to-v9.x
Closed
[v9.x backport] doc: add new documentation rule#19189estrada9166 wants to merge 1 commit intonodejs:v9.x-stagingfrom estrada9166:backport-18726-to-v9.x
estrada9166 wants to merge 1 commit intonodejs:v9.x-stagingfrom
estrada9166:backport-18726-to-v9.x
Conversation
nodejs-github-bot
added
build
MylesBorins
force-pushed
the
v9.x-staging
branch
2 times, most recently
from
4e9ac10 to
50d1233
Compare
Contributor
|
landed in cde6671 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 7, 2018
Add 80 characters limit to docs. Change docs to fit 80 characters per row. Backport-PR-URL: #19189 PR-URL: #18726 Fixes: #18703 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Contributor
|
Failing on OSX when running edit: backed out of staging. Please rebase and attempt to get it working locally. Thanks! |
Contributor
Author
|
@MylesBorins I thought it was solved in this PR and the |
Contributor
Author
|
@joyeecheung Do you know what can be happening? I thought it was solved in your PR |
Member
|
@estrada9166 That PR fixes |
This was referenced Mar 9, 2018
MylesBorins
force-pushed
the
v9.x-staging
branch
3 times, most recently
from
d457b9d to
03c321a
Compare
3 tasks
Contributor
|
ping @estrada9166 |
Contributor
Author
|
@MylesBorins I'm waiting some comments on this PR, it solve the error that you got |
targos
pushed a commit
that referenced
this pull request
Mar 24, 2018
Add 80 characters limit to docs. Change docs to fit 80 characters per row. Backport-PR-URL: #19189 PR-URL: #18726 Fixes: #18703 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Member
|
Fixed conflict and landed in 26e97a1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting doc changes.
Refs: #18726 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesDoc