[v8.x backport] trace_events: add file pattern cli option#19145
Closed
AndreasMadsen wants to merge 1 commit intonodejs:v8.x-stagingfrom
AndreasMadsen:backport-18480-to-v8.x
Closed
[v8.x backport] trace_events: add file pattern cli option#19145AndreasMadsen wants to merge 1 commit intonodejs:v8.x-stagingfrom AndreasMadsen:backport-18480-to-v8.x
AndreasMadsen wants to merge 1 commit intonodejs:v8.x-stagingfrom
AndreasMadsen:backport-18480-to-v8.x
Conversation
nodejs-github-bot
added
c++
AndreasMadsen
added
trace_events
Member
Author
Allow the user to specify the filepath for the trace_events log file using a template string. PR-URL: #18480 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
Author
|
Failed because we create temporary directories differently in node 8 in our tests. |
Member
Author
|
Unrelated test failure:
|
MylesBorins
force-pushed
the
v8.x-staging
branch
2 times, most recently
from
44cb0d3 to
16bf5fe
Compare
Contributor
|
@nodejs/lts @nodejs/collaborators I'm landing this on staging preparing for a semver-minor release. Please lmk if you htink we should back it out |
Contributor
|
landed in a1d0e5a040 |
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
Allow the user to specify the filepath for the trace_events log file using a template string. Backport-PR-URL: #19145 PR-URL: #18480 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 14, 2018
Allow the user to specify the filepath for the trace_events log file using a template string. Backport-PR-URL: #19145 PR-URL: #18480 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
rvagg
pushed a commit
that referenced
this pull request
Aug 16, 2018
Allow the user to specify the filepath for the trace_events log file using a template string. Backport-PR-URL: #19145 PR-URL: #18480 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the user to specify the filepath for the trace_events log file
using a template string.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
trace-events