doc: improve onboarding instructions#19108
Closed
joyeecheung wants to merge 2 commits intonodejs:masterfrom
Closed
doc: improve onboarding instructions#19108joyeecheung wants to merge 2 commits intonodejs:masterfrom
joyeecheung wants to merge 2 commits intonodejs:masterfrom
Conversation
- Suggest to use a TOTP app if the new collaborator cannot receive SMS messages from GitHub - Suggest to install node-core-utils and set up credentials before the onboarding session. - Ask about subsystem teams that they want to join - Note about squashing commits - Other small fixes
richardlau
approved these changes
Mar 3, 2018
COLLABORATOR_GUIDE.md
Outdated
| to type the password of your GitHub account in the console so the tool can | ||
| create the GitHub access token for you. If you do not want to do that, follow | ||
| [the guide of `node-core-utils`][node-core-utils-credentials] | ||
| to type the password of your GitHub account and the 2FA code in the console |
Member
There was a problem hiding this comment.
The onboarding doc writes out two-factor authentication and links to the GitHub help page.
Member
|
As an aside, I just started using |
vsemozhetbyt
reviewed
Mar 3, 2018
| * [`node-core-utils`][] automates the generation of metadata and the landing | ||
| process. See the documentation of [`git-node`][]. | ||
| * [`core-validate-commit`][] automates the validation of commit messages. | ||
| This will be run during `git node land --final` of the [`git-node`][] |
Contributor
There was a problem hiding this comment.
Nit: it seems [`git-node`][] URL needs updating.
lpinca
approved these changes
Mar 3, 2018
Trott
reviewed
Mar 3, 2018
doc/onboarding.md
Outdated
| [using a TOTP mobile app][]. | ||
| * Announce the accepted nomination in a TSC meeting and in the TSC | ||
| mailing list. | ||
| * Suggest the new Collaborator to install [`node-core-utils`][] and |
jasnell
approved these changes
Mar 5, 2018
gibfahn
reviewed
Mar 5, 2018
COLLABORATOR_GUIDE.md
Outdated
| @@ -471,9 +471,9 @@ $ git node land $PRID | |||
| ``` | |||
|
|
|||
| If it's the first time you ever use `node-core-utils`, you will be prompted | |||
Member
There was a problem hiding this comment.
I know it's not changed in this PR, but while you're here:
you ever use -> you have used
COLLABORATOR_GUIDE.md
Outdated
| [the guide of `node-core-utils`][node-core-utils-credentials] | ||
| to type the password of your GitHub account and the 2FA code in the console | ||
| so the tool can create the GitHub access token for you. If you do not want to | ||
| do that, follow [the guide of `node-core-utils`][node-core-utils-credentials] |
Member
There was a problem hiding this comment.
the guide of node-core-utils -> the node-core-utils guide
doc/onboarding.md
Outdated
|
|
||
| * Prior to the onboarding session, add the new Collaborator to | ||
| [the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators). | ||
| * Ask them if they want to join any subsystem team. See |
Member
Author
|
Fixed nits. Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/233/ |
richardlau
approved these changes
Mar 7, 2018
Member
Author
|
Landed in 42e9b48, thanks! |
joyeecheung
added a commit
that referenced
this pull request
Mar 7, 2018
- Suggest to use a TOTP app if the new collaborator cannot receive SMS messages from GitHub - Suggest to install node-core-utils and set up credentials before the onboarding session. - Ask about subsystem teams that they want to join - Note about squashing commits - Other small fixes PR-URL: #19108 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 17, 2018
- Suggest to use a TOTP app if the new collaborator cannot receive SMS messages from GitHub - Suggest to install node-core-utils and set up credentials before the onboarding session. - Ask about subsystem teams that they want to join - Note about squashing commits - Other small fixes PR-URL: #19108 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 20, 2018
- Suggest to use a TOTP app if the new collaborator cannot receive SMS messages from GitHub - Suggest to install node-core-utils and set up credentials before the onboarding session. - Ask about subsystem teams that they want to join - Note about squashing commits - Other small fixes PR-URL: #19108 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
- Suggest to use a TOTP app if the new collaborator cannot receive SMS messages from GitHub - Suggest to install node-core-utils and set up credentials before the onboarding session. - Ask about subsystem teams that they want to join - Note about squashing commits - Other small fixes PR-URL: nodejs#19108 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Member
|
Doesn't need to be landed in 8.x or 6.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SMS messages from GitHub
the onboarding session.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc