build: fix gocvr version used for coverage#19094
Closed
mhdawson wants to merge 1 commit intonodejs:masterfrom
Closed
build: fix gocvr version used for coverage#19094mhdawson wants to merge 1 commit intonodejs:masterfrom
mhdawson wants to merge 1 commit intonodejs:masterfrom
Conversation
Fix the gcovr version to a fixed version and uses patches specific to that version. This avoids us being broken by changes in the gcovr repo. Using file name for patches specific to the version level will allow us to move up when necessary without breaking coverage for earlier versions of Node.js
nodejs-github-bot
added
the
build
Member
Author
|
@killagu, FYI making this change so that we are less likely to run into problems in the future. |
Member
Author
gibfahn
approved these changes
Mar 5, 2018
Member
gibfahn
left a comment
gibfahn
left a comment
There was a problem hiding this comment.
LGTM given that it's been tested.
Member
Author
|
CI run was good, failure on ppc-be was infra issue. |
mhdawson
changed the title
Member
Author
|
Landed as 29697ef |
mhdawson
added a commit
that referenced
this pull request
Mar 5, 2018
Fix the gcovr version to a fixed version and uses patches specific to that version. This avoids us being broken by changes in the gcovr repo. Using file name for patches specific to the version level will allow us to move up when necessary without breaking coverage for earlier versions of Node.js PR-URL: #19094 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 6, 2018
Fix the gcovr version to a fixed version and uses patches specific to that version. This avoids us being broken by changes in the gcovr repo. Using file name for patches specific to the version level will allow us to move up when necessary without breaking coverage for earlier versions of Node.js PR-URL: #19094 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 6, 2018
Fix the gcovr version to a fixed version and uses patches specific to that version. This avoids us being broken by changes in the gcovr repo. Using file name for patches specific to the version level will allow us to move up when necessary without breaking coverage for earlier versions of Node.js PR-URL: #19094 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 6, 2018
Fix the gcovr version to a fixed version and uses patches specific to that version. This avoids us being broken by changes in the gcovr repo. Using file name for patches specific to the version level will allow us to move up when necessary without breaking coverage for earlier versions of Node.js PR-URL: #19094 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 6, 2018
Fix the gcovr version to a fixed version and uses patches specific to that version. This avoids us being broken by changes in the gcovr repo. Using file name for patches specific to the version level will allow us to move up when necessary without breaking coverage for earlier versions of Node.js PR-URL: #19094 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 7, 2018
Fix the gcovr version to a fixed version and uses patches specific to that version. This avoids us being broken by changes in the gcovr repo. Using file name for patches specific to the version level will allow us to move up when necessary without breaking coverage for earlier versions of Node.js PR-URL: #19094 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Member
|
This may be related to #19057. |
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Fix the gcovr version to a fixed version and uses patches specific to that version. This avoids us being broken by changes in the gcovr repo. Using file name for patches specific to the version level will allow us to move up when necessary without breaking coverage for earlier versions of Node.js PR-URL: nodejs#19094 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Member
|
Does this need to be backported to 8.x? If so, please open a backport PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the gcovr version to a fixed version and use patches
specific to that version. This avoids us being broken by
changes in the gcovr repo. Using file name for patches
specific to the version level will allow us to move up when
necessary without breaking coverage for earlier versions
of Node.js
This also reverts the logic back to what it was before the change we landed
earlier this week as that works with the 3.4 version of gcovr which is the
latest tagged version.
Marked as WIP as needs nodejs/build#1162 to land first.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build