v9.7.1 release proposal

[rvagg]

Ref: #19074

No commits in here, busted .pkg file so we're pushing out a new release rather than overwriting.

[devsnek]

can we include bug fix #18949

[rvagg]

no, sorry @devsnek, gotta get a pristine release out. If that fix is urgent enough we can queue up a new release, there's no firm restriction on how often Current releases go out.

[rvagg]

For the record, here's what happened:

I built 9.7.0 yesterday but one of the Windows builders looked like it stalled just after signing the package, even after waiting 10 minutes it stayed on the same output. So I started a new build with the same parameters just in case I needed it. After a short period I noticed that the stuck Windows builder had finished successfully, so I cancelled the second job because I no longer needed it.

It just so happens that I cancelled it in the middle of the macOS pkg builder uploading its file into staging:

scp -p node-v9.7.0.pkg node-www:nodejs/release/v9.7.0/node-v9.7.0.pkg
Killed by signal 15.

We have a "lock file" that's used to indicate that uploads are complete, our promotion tooling won't promote a release file without the presence of this second lock file to indicate it was complete. Unfortunately in this instance the lock file was already in place thanks to the first builder and the second builder was writing a new file but never finished it. Our promotion tooling saw an indication that the file was complete and assumed it could promote.

Possible fixes:

• delete the lock file if it exists prior to uploading the new file (see Makefile and vcbuild.dat and look for references to .done)
• upload the new file with a temporary name or in a temporary directory and copy it to the final location and touch the lock file in a single ssh operation (not atomic, but close enough I think, mv .. && touch ..)
• something on the Jenkins side to gate these operations, I'm not sure what that would be without being disruptive to our regular nightly builds though

[rvagg]

done & released

[MylesBorins]

Thanks for putting this together@rvagg