Closed
Conversation
richardlau
reviewed
Feb 16, 2018
Member
There was a problem hiding this comment.
I wonder if the logic for getting the shared lib instead of the stub executable is worth putting in the test/common/shared-lib-util.js being added in #18626. The platform specific logic could then be kept out of these changes.
Member
Author
There was a problem hiding this comment.
sure. that would be great! Since that PR is not landed yet. I will do that after the merge.
Member
Author
There was a problem hiding this comment.
@richardlau per your suggestion and the PR is landed, I moved the shared lib path logic into test/common/shared-lib-util.js
yhwang
force-pushed
the
sharedlib-test-fix-postmortem
branch
from
beedb23 to
39c2edf
Compare
cjihrig
reviewed
Feb 16, 2018
Contributor
There was a problem hiding this comment.
Why not just conditionally create args?
yhwang
force-pushed
the
sharedlib-test-fix-postmortem
branch
from
39c2edf to
79842cc
Compare
richardlau
approved these changes
Feb 16, 2018
richardlau
reviewed
Feb 16, 2018
test/common/shared-lib-util.js
Outdated
yhwang
force-pushed
the
sharedlib-test-fix-postmortem
branch
from
79842cc to
0da2151
Compare
BridgeAR
approved these changes
Feb 17, 2018
BridgeAR
added
the
author ready
Member
cjihrig
approved these changes
Feb 17, 2018
gibfahn
approved these changes
Feb 19, 2018
hiroppy
approved these changes
Feb 19, 2018
Member
Author
|
debian8-x64 failed on |
Member
Author
|
previous CI passed the windows build and the second CI passed the linux test. I think it's green for this change. |
When building the node with `--shared` option, we need to verify the symbols in shared lib instead of executable. Refs: nodejs#18535 Signed-off-by: Yihong Wang <yh.wang@ibm.com>
yhwang
force-pushed
the
sharedlib-test-fix-postmortem
branch
from
0da2151 to
01374fe
Compare
Member
Author
|
rebased because of the conflict and new CI: https://ci.nodejs.org/job/node-test-commit/16393/ |
addaleax
approved these changes
Feb 21, 2018
Member
|
Landed in ab7c627 |
addaleax
pushed a commit
that referenced
this pull request
Feb 21, 2018
When building the node with `--shared` option, we need to verify the symbols in shared lib instead of executable. Refs: #18535 Signed-off-by: Yihong Wang <yh.wang@ibm.com> PR-URL: #18806 Refs: #18535 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Member
Author
|
thanks @addaleax |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 6, 2018
When building the node with `--shared` option, we need to verify the symbols in shared lib instead of executable. Refs: #18535 Signed-off-by: Yihong Wang <yh.wang@ibm.com> PR-URL: #18806 Refs: #18535 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 6, 2018
When building the node with `--shared` option, we need to verify the symbols in shared lib instead of executable. Refs: #18535 Signed-off-by: Yihong Wang <yh.wang@ibm.com> PR-URL: #18806 Refs: #18535 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
When building the node with `--shared` option, we need to verify the symbols in shared lib instead of executable. Refs: nodejs#18535 Signed-off-by: Yihong Wang <yh.wang@ibm.com> PR-URL: nodejs#18806 Refs: nodejs#18535 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 7, 2018
When building the node with `--shared` option, we need to verify the symbols in shared lib instead of executable. Refs: #18535 Signed-off-by: Yihong Wang <yh.wang@ibm.com> PR-URL: #18806 Refs: #18535 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 7, 2018
When building the node with `--shared` option, we need to verify the symbols in shared lib instead of executable. Refs: #18535 Signed-off-by: Yihong Wang <yh.wang@ibm.com> PR-URL: #18806 Refs: #18535 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 9, 2018
When building the node with `--shared` option, we need to verify the symbols in shared lib instead of executable. Refs: #18535 Signed-off-by: Yihong Wang <yh.wang@ibm.com> PR-URL: #18806 Refs: #18535 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Aug 16, 2018
When building the node with `--shared` option, we need to verify the symbols in shared lib instead of executable. Refs: #18535 Signed-off-by: Yihong Wang <yh.wang@ibm.com> PR-URL: #18806 Refs: #18535 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building the node with
--sharedoption, we needto verify the symbols in shared lib instead of executable.
Refs: #18535
Signed-off-by: Yihong Wang yh.wang@ibm.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test