Closed
Conversation
Move the print statements below a console.log call.
nodejs-github-bot
added
buffer
4 tasks
Member
Author
benjamingr
approved these changes
Feb 13, 2018
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
+0 on putting the comments below (and I'm not a fan of the churn here tbh). Actual changes LGTM (and nice other fixes)
BridgeAR
added
the
author ready
jasnell
approved these changes
Feb 13, 2018
vsemozhetbyt
approved these changes
Feb 14, 2018
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Feb 16, 2018
Move the print statements below a console.log call. PR-URL: nodejs#18758 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Member
Author
|
Landed in 759a083 |
Contributor
|
Should this be backported to |
4 tasks
Member
Author
|
Backported in #19244 |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Mar 21, 2018
Move the print statements below a console.log call. PR-URL: nodejs#18758 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Move the print statements below a console.log call. PR-URL: nodejs#18758 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Contributor
|
Backport requested for 8.x in #19244 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches the order of the print statements. In most docs we have them below so it is clear that it is "output" while other things are above to describe what is triggered.
It is also easier to group output that way.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
docs