Closed
Conversation
The current stack trace thrown in case `assert.throws(fn, object)` is used did not filter the stack trace. This fixes it.
nodejs-github-bot
added
the
assert
Member
Author
jasnell
approved these changes
Feb 6, 2018
apapirovski
approved these changes
Feb 6, 2018
Contributor
apapirovski
left a comment
apapirovski
left a comment
There was a problem hiding this comment.
LGTM with a small nit
lib/assert.js
Outdated
| return msg; | ||
| return `${key}: expected ${inspect(expected[key])}, ` + | ||
| `not ${inspect(actual[key])}`; | ||
| function compareKey(actual, expected, key, msg) { |
Contributor
There was a problem hiding this comment.
Nit: could we give this function a slightly more descriptive name since it only works for throws? Like compareExceptionKey or something?
BridgeAR
added
the
author ready
apapirovski
approved these changes
Feb 6, 2018
Member
Author
|
I only changed the function name since the CI and it was green before, so I do not rerun it now. |
apapirovski
pushed a commit
to apapirovski/node
that referenced
this pull request
Feb 9, 2018
The current stack trace thrown in case `assert.throws(fn, object)` is used did not filter the stack trace. This fixes it. PR-URL: nodejs#18595 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Contributor
|
Landed in cccddc5 |
Contributor
|
Should this be backported to |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Mar 8, 2018
The current stack trace thrown in case `assert.throws(fn, object)` is used did not filter the stack trace. This fixes it. PR-URL: nodejs#18595 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
4 tasks
Member
Author
|
Backport opened in #19230 |
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
The current stack trace thrown in case `assert.throws(fn, object)` is used did not filter the stack trace. This fixes it. PR-URL: nodejs#18595 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Contributor
|
Requested backport to 8.x in #19230 |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Oct 2, 2018
The current stack trace thrown in case `assert.throws(fn, object)` is used did not filter the stack trace. This fixes it. PR-URL: nodejs#18595 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current stack trace thrown in case
assert.throws(fn, object)is used did not filter the stack trace. This fixes it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
assert