deps: V8: resolve remaining whitespace diff#18366
Merged
ofrobots merged 1 commit intonodejs:masterfrom Jan 31, 2018
Merged
Conversation
nodejs-github-bot
added
the
v8 engine
Contributor
MylesBorins
approved these changes
Jan 25, 2018
Contributor
MylesBorins
left a comment
MylesBorins
left a comment
There was a problem hiding this comment.
This LGTM but I likely shouldn't sign off on my own commit
cjihrig
approved these changes
Jan 25, 2018
jasnell
approved these changes
Jan 26, 2018
Some whitespace was lost when nodejs#17489 landed. While I restored the one file causing the V8-CI to fail, I missed the remaining changes from Myles. This changes restores all whitespace differences with upstream. PR-URL: nodejs#18366 Refs: nodejs#18360 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
ofrobots
force-pushed
the
more-whitespace
branch
from
9a413fa to
70277d6
Compare
Contributor
Author
|
Landed in 70277d6. |
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Some whitespace was lost when nodejs#17489 landed. While I restored the one file causing the V8-CI to fail, I missed the remaining changes from Myles. This changes restores all whitespace differences with upstream. PR-URL: nodejs#18366 Refs: nodejs#18360 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background: #18360. I made a mistake in picking up the patch from @MylesBorins (sorry!), and ended up restoring whitespace in the only one file that was breaking V8-CI. That was enough to fix the V8-CI. This patch picks up the remaining whitespace delta.
Refs: #18360
Affected core subsystem(s)
deps: V8