module: validate paths early, use internal/errors.js#18359
Closed
joyeecheung wants to merge 4 commits intonodejs:masterfrom
Closed
module: validate paths early, use internal/errors.js#18359joyeecheung wants to merge 4 commits intonodejs:masterfrom
joyeecheung wants to merge 4 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
errors
Member
Author
jasnell
approved these changes
Jan 24, 2018
cjihrig
approved these changes
Jan 25, 2018
lib/internal/errors.js
Outdated
Contributor
There was a problem hiding this comment.
Just pointing out that this was only executed once in the past, and is now executed each time through the code path.
Member
Author
There was a problem hiding this comment.
Good catch, I'll fix it
joyeecheung
force-pushed
the
throw-module-error
branch
from
dde8589 to
83edd35
Compare
Member
Author
joyeecheung
added
semver-major
joyeecheung
force-pushed
the
throw-module-error
branch
from
83edd35 to
8cb4832
Compare
Member
Author
|
Rebased. CI before landing: https://ci.nodejs.org/job/node-test-pull-request/12793/ |
Member
Author
|
Landed in 3ec7921...9fb91fe. Thanks! |
joyeecheung
removed
the
author ready
joyeecheung
added a commit
that referenced
this pull request
Jan 29, 2018
PR-URL: #18359 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
joyeecheung
added a commit
that referenced
this pull request
Jan 29, 2018
PR-URL: #18359 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18359 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18359 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18359 Fixes: nodejs#18352 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18359 Fixes: nodejs#18352 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #18352
First commit is taken from #18358 for better descriptions of errors.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
module