build: fix rm commands in tarball rule#18332
Closed
bnoordhuis wants to merge 1 commit intonodejs:masterfrom
Closed
build: fix rm commands in tarball rule#18332bnoordhuis wants to merge 1 commit intonodejs:masterfrom
bnoordhuis wants to merge 1 commit intonodejs:masterfrom
Conversation
The `$(RM) {foo,bar,baz}` rules don't seem to work with GNU make 4.1.
Write them out in full and get rid of a few overlong lines in the
process.
nodejs-github-bot
added
the
build
jasnell
approved these changes
Jan 24, 2018
cjihrig
approved these changes
Jan 24, 2018
joyeecheung
approved these changes
Jan 24, 2018
Member
richardlau
approved these changes
Jan 24, 2018
maclover7
approved these changes
Jan 26, 2018
maclover7
added
the
author ready
Contributor
|
Landing... |
Contributor
|
Landed in 09ef021 |
2 tasks
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
The `$(RM) {foo,bar,baz}` rules don't seem to work with GNU make 4.1.
Write them out in full and get rid of a few overlong lines in the
process.
PR-URL: #18332
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
addaleax
added
author ready
Contributor
|
Should this be backported to |
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
The `$(RM) {foo,bar,baz}` rules don't seem to work with GNU make 4.1.
Write them out in full and get rid of a few overlong lines in the
process.
PR-URL: nodejs#18332
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
BethGriggs
pushed a commit
to BethGriggs/node
that referenced
this pull request
Jul 10, 2018
The `$(RM) {foo,bar,baz}` rules don't seem to work with GNU make 4.1.
Write them out in full and get rid of a few overlong lines in the
process.
PR-URL: nodejs#18332
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
2 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jul 13, 2018
The `$(RM) {foo,bar,baz}` rules don't seem to work with GNU make 4.1.
Write them out in full and get rid of a few overlong lines in the
process.
Backport-PR-URL: #21738
PR-URL: #18332
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
rvagg
pushed a commit
that referenced
this pull request
Aug 16, 2018
The `$(RM) {foo,bar,baz}` rules don't seem to work with GNU make 4.1.
Write them out in full and get rid of a few overlong lines in the
process.
Backport-PR-URL: #21738
PR-URL: #18332
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
$(RM) {foo,bar,baz}rules don't seem to work with GNU make 4.1.Write them out in full and get rid of a few overlong lines in the
process.
edit: see #18287 (comment)