test: fix unreliable async-hooks/test-signalwrap#17827
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
test: fix unreliable async-hooks/test-signalwrap#17827Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
Use an interval to keep the event loop open so the test does not exit before receiving all signals fom asynchronous `exec()` calls. Fixes: nodejs#14070
Trott
added
async_hooks
nodejs-github-bot
added
async_hooks
Member
Author
Member
Author
|
Stress test showing failures on master: https://ci.nodejs.org/job/node-stress-single-test/1571/nodes=alpine34-container-x64/console Stress test with same parameters but on this PR (hopefully showing no failures when it finishes): https://ci.nodejs.org/job/node-stress-single-test/1573/nodes=alpine34-container-x64/console |
cjihrig
approved these changes
Dec 22, 2017
gibfahn
approved these changes
Dec 22, 2017
Member
Author
|
CI is green, stress test for master is red, stress test for this PR is green. 🎉 |
maclover7
added
the
author ready
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 25, 2017
Use an interval to keep the event loop open so the test does not exit before receiving all signals fom asynchronous `exec()` calls. PR-URL: nodejs#17827 Fixes: nodejs#14070 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Member
Author
|
Landed in 457ceeb |
addaleax
removed
the
author ready
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use an interval to keep the event loop open so the test does not exit
before receiving all signals fom asynchronous
exec()calls.Fixes: #14070
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test async_hooks