test: refactor test-repl-definecommand#17795
Closed
Trott wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
The test was writing to both REPL input and output but only checking output. Sending output to both streams seems like it was an error.
BridgeAR
reviewed
Dec 21, 2017
| assert(/\n\.say1 help for say1\n/.test(output), | ||
| 'help for say1 not present'); | ||
| assert.ok(/\n\.say1 help for say1\n/.test(output), | ||
| 'help for say1 not present'); |
Member
There was a problem hiding this comment.
This seems to be a independent change. I do not really see why this should be changed?
Member
Author
There was a problem hiding this comment.
I was trying to standardize on assert.ok() for tests, but I see I also missed one on another line. Anyway, yes, it's unnecessary, so I'll undo it.
jasnell
approved these changes
Dec 21, 2017
Member
Author
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 21, 2017
The test was writing to both REPL input and output but only checking output. Sending output to both streams seems like it was an error. PR-URL: nodejs#17795 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
|
Landed in c90b10d |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
The test was writing to both REPL input and output but only checking output. Sending output to both streams seems like it was an error. PR-URL: #17795 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
The test was writing to both REPL input and output but only checking output. Sending output to both streams seems like it was an error. PR-URL: #17795 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
The test was writing to both REPL input and output but only checking output. Sending output to both streams seems like it was an error. PR-URL: #17795 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Jan 24, 2018
The test was writing to both REPL input and output but only checking output. Sending output to both streams seems like it was an error. PR-URL: #17795 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Jan 24, 2018
The test was writing to both REPL input and output but only checking output. Sending output to both streams seems like it was an error. PR-URL: #17795 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Jan 24, 2018
The test was writing to both REPL input and output but only checking output. Sending output to both streams seems like it was an error. PR-URL: #17795 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 11, 2018
The test was writing to both REPL input and output but only checking output. Sending output to both streams seems like it was an error. PR-URL: #17795 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 12, 2018
The test was writing to both REPL input and output but only checking output. Sending output to both streams seems like it was an error. PR-URL: #17795 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 13, 2018
The test was writing to both REPL input and output but only checking output. Sending output to both streams seems like it was an error. PR-URL: #17795 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was writing to both REPL input and output but only checking
output. Sending output to both streams seems like it was an error.
/cc @bmeck
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test repl