src: remove unused strings from env.h#17643
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
nodejs-github-bot
added
the
c++
Member
Author
addaleax
added
lib / src
gireeshpunathil
approved these changes
Dec 13, 2017
Member
|
@addaleax - just wondering how these strings came into being in the first place? they were used once and orphaned by the PRs over time? |
Member
Author
|
@gireeshpunathil Yeah, I would assume exactly that. 👍 |
danbev
approved these changes
Dec 13, 2017
BridgeAR
approved these changes
Dec 13, 2017
cjihrig
approved these changes
Dec 13, 2017
maclover7
approved these changes
Dec 13, 2017
Contributor
maclover7
left a comment
maclover7
left a comment
There was a problem hiding this comment.
LGTM if CI passes
Maybe a little bit of a stretch, but is there any kind of lint rule we can apply to check for this?
lpinca
approved these changes
Dec 13, 2017
Member
|
The best one was |
jasnell
approved these changes
Dec 13, 2017
Member
Author
|
Landed in de22009 |
addaleax
added a commit
that referenced
this pull request
Dec 16, 2017
PR-URL: #17643 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
PR-URL: #17643 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
PR-URL: #17643 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Contributor
|
Setting Don't land for both 6.x and 8.x. If you would like to backport or do the same work on one of the LTS lines feel free, but I don't think it is necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes (presumably)Affected core subsystem(s)
src