deps: upgrade npm to 5.6.0 by zkat · Pull Request #17535 · nodejs/node

zkat · 2017-12-07T22:35:24Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

deps

Description of Changes

Here it is! It's been a long time coming, what with conference season, vacations, and everyone getting sick, but I think folks have been expecting this one for a bit. This is another fairly sizeable release, as far as impact goes, and did include some refactoring, but it's been sitting in @next for a week and has gotten some use from folks, so we think it's ready to bump in Node!

The most important thing with this release is, probably, that npm now works with node@9 out of the box. Previously, y'all had floated a patch over 5.5.1, but this change integrates it directly. 🎉

Other changes of note to node folks:

npm/npm@66d18280c npm/npm#19104 Add new --node-options config to pass through a custom NODE_OPTIONS for lifecycle scripts. (@bmeck)
npm/npm@c930e98ad npm-lifecycle@2.0.0: npm's node-gyp is now included as part of an external library, npm-lifecycle, so any future PRs by Node folks to bump or adjust node-gyp versions should be made against https://github.com/npm/lifecycle instead. (@zkochan)
bc263c3fd #19054 Fully cross-platform package-lock.json. Installing a failing optional dependency on one platform no longer removes it from the dependency tree, meaning that package-lock.json should now be generated consistently across platforms! 🎉 (@iarna)
A whole slew of bugfixes, including some for platforms like Docker and Windows which should fix further issues.

Changelogs

v5.6.0

MylesBorins · 2017-12-08T04:05:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/11968/

evanlucas

yay! Thanks @zkat!

Rubberstamp LGTM

fishcharlie · 2017-12-12T01:52:00Z

Any idea when this will make it into a Node.js release?

BridgeAR · 2017-12-12T14:56:59Z

I am a bit confused about the first commit. Is it intentionally added here?

zkat · 2017-12-12T20:14:03Z

@BridgeAR oh weird. Lemme get rid of that right quick. I probably messed up the rebase (or the staging branch had that commit removed/rewritten)

richardlau · 2017-12-12T23:21:28Z

Is there a reason this is targeted at v9.x-staging and not master?

zkat · 2017-12-12T23:25:59Z

@richardlau because node@10 is not yet supported by npm, and you're gonna get a big ugly warning that's gonna make the tests fail if you try.

PR-URL: nodejs#17535 Reviewed-By: Evan Lucas <evanlucas@me.com>

corvinrok · 2017-12-14T22:23:17Z

Will this also be considered for the 8.x line?

BridgeAR · 2017-12-15T20:13:55Z

@zkat is there a nice way to get the tests to pass on Node.js v.10? Because it would be great to also have the newest npm version also on master. Maybe passing a flag that could make the test pass?

BridgeAR

Rubberstamp LGTM

MylesBorins

LGTM

PR-URL: #17535 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>

PR-URL: #17774 Notable Changes: * deps: * upgrade npm to 5.6.0 (Kat Marchán) [#17535](#17535) * build: * configure can now be run from any directory (Gibson Fahnestock) [#17321](#17321)

Notable change: * async_hooks: - deprecate AsyncHooks Sensitive API and runInAsyncIdScope. Neither API were documented. (Andreas Madsen) #16972 * deps: - update nghttp2 to 1.29.0 (James M Snell) #17908 - upgrade npm to 5.6.0 (Kat Marchán) #17535 - cherry-pick 50f7455 from upstream V8 (Michaël Zasso) #16591 * events: - remove reaches into _events internals (Anatoli Papirovski) #17440 * http: - add rawPacket in err of `clientError` event (XadillaX) #17672 * http2: - implement maxSessionMemory (James M Snell) #17967 - add initial support for originSet (James M Snell) #17935 - add altsvc support (James M Snell) #17917 - perf_hooks integration (James M Snell) #17906 * net: - remove Socket.prototype.write (Anna Henningsen) #17644 - remove Socket.prototype.listen (Ruben Bridgewater) #13735 * repl: - show lexically scoped vars in tab completion (Michaël Zasso) #16591 * stream: - rm {writeable/readable}State.length (Calvin Metcalf) #12857 - add flow and buffer properties to streams (Calvin Metcalf) #12855 * util: - allow wildcards in NODE_DEBUG variable (Tyler) #17609 * zlib: - add ArrayBuffer support (Jem Bezooyen) #16042 * Addedew collaborator** - [starkwang](https://github.com/starkwang) Weijia Wang * Addedew TSC member** - [danbev](https://github.com/danbev) Daniel Bevenius PR-URL: #18069

Notable change: * async_hooks: - deprecate AsyncHooks Sensitive API and runInAsyncIdScope. Neither API were documented. (Andreas Madsen) #16972 * deps: - update nghttp2 to 1.29.0 (James M Snell) #17908 - upgrade npm to 5.6.0 (Kat Marchán) #17535 - cherry-pick 50f7455 from upstream V8 (Michaël Zasso) #16591 * events: - remove reaches into _events internals (Anatoli Papirovski) #17440 * http: - add rawPacket in err of `clientError` event (XadillaX) #17672 * http2: - implement maxSessionMemory (James M Snell) #17967 - add initial support for originSet (James M Snell) #17935 - add altsvc support (James M Snell) #17917 - perf_hooks integration (James M Snell) #17906 - Refactoring and cleanup of Http2Session and Http2Stream destroy (James M Snell) #17406 * net: - remove Socket.prototype.write (Anna Henningsen) #17644 - remove Socket.prototype.listen (Ruben Bridgewater) #13735 * repl: - show lexically scoped vars in tab completion (Michaël Zasso) #16591 * stream: - rm {writeable/readable}State.length (Calvin Metcalf) #12857 - add flow and buffer properties to streams (Calvin Metcalf) #12855 * util: - allow wildcards in NODE_DEBUG variable (Tyler) #17609 * zlib: - add ArrayBuffer support (Jem Bezooyen) #16042 * Addedew collaborator** - [starkwang](https://github.com/starkwang) Weijia Wang * Addedew TSC member** - [danbev](https://github.com/danbev) Daniel Bevenius PR-URL: #18069

Currently npm explicitly doesn't support 10.x and will fail on master. This patch manually adds support for 10.x so that we can keep an up to date version of npm on master. refs: #17535 PR-URL: #17777 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

Currently npm explicitly doesn't support 10.x and will fail on master. This patch manually adds support for 10.x so that we can keep an up to date version of npm on master. refs: nodejs#17535 PR-URL: nodejs#17777 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

Currently npm explicitly doesn't support 10.x and will fail on master. This patch manually adds support for 10.x so that we can keep an up to date version of npm on master. refs: #17535 Backport-PR-URL: #19560 PR-URL: #17777 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

Currently npm explicitly doesn't support 10.x and will fail on master. This patch manually adds support for 10.x so that we can keep an up to date version of npm on master. refs: nodejs#17535 PR-URL: nodejs#17777 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Dec 7, 2017

addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label Dec 7, 2017

zkat force-pushed the npm-5.6.0 branch from 42940ef to d31775c Compare December 7, 2017 22:44

zkat changed the base branch from master to v9.x-staging December 7, 2017 22:44

MylesBorins self-requested a review December 8, 2017 04:04

evanlucas approved these changes Dec 8, 2017

View reviewed changes

MylesBorins force-pushed the v9.x-staging branch from 84620d8 to f0f9e1a Compare December 8, 2017 14:09

addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 11, 2017

MylesBorins force-pushed the v9.x-staging branch from 3387fe4 to 778d783 Compare December 12, 2017 06:53

zkat force-pushed the npm-5.6.0 branch from d31775c to df4e08f Compare December 12, 2017 20:15

MylesBorins force-pushed the v9.x-staging branch from f814321 to b8ecf3c Compare December 12, 2017 20:57

deps: upgrade npm to 5.6.0

e7d1336

zkat force-pushed the npm-5.6.0 branch from df4e08f to e7d1336 Compare December 12, 2017 22:17

addaleax pushed a commit to addaleax/node that referenced this pull request Dec 13, 2017

deps: upgrade npm to 5.6.0

7fda797

PR-URL: nodejs#17535 Reviewed-By: Evan Lucas <evanlucas@me.com>

addaleax added the v9.x label Dec 13, 2017

bnoordhuis mentioned this pull request Dec 13, 2017

big-bug: Upgrade to npm 5.6 #17645

Closed

BridgeAR approved these changes Dec 15, 2017

View reviewed changes

MylesBorins approved these changes Dec 20, 2017

View reviewed changes

MylesBorins removed the semver-minor PRs that contain new features and should be released in the next minor version. label Dec 20, 2017

MylesBorins pushed a commit that referenced this pull request Dec 20, 2017

deps: upgrade npm to 5.6.0

df94fa5

PR-URL: #17535 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>

addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 29, 2017

MylesBorins mentioned this pull request Jan 10, 2018

v9.4.0 proposal #18069

Merged

MylesBorins added the dont-land-on-v6.x label Jan 22, 2018

richardlau mentioned this pull request Feb 5, 2018

deps: update npm to v5.5.1 #16509

Closed

wraithgar deleted the npm-5.6.0 branch June 26, 2025 15:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

deps: upgrade npm to 5.6.0#17535

deps: upgrade npm to 5.6.0#17535
zkat wants to merge 1 commit intonodejs:v9.x-stagingfrom
npm:npm-5.6.0

zkat commented Dec 7, 2017

Uh oh!

MylesBorins commented Dec 8, 2017

Uh oh!

evanlucas left a comment

Uh oh!

fishcharlie commented Dec 12, 2017

Uh oh!

BridgeAR commented Dec 12, 2017

Uh oh!

zkat commented Dec 12, 2017

Uh oh!

richardlau commented Dec 12, 2017

Uh oh!

zkat commented Dec 12, 2017

Uh oh!

corvinrok commented Dec 14, 2017

Uh oh!

BridgeAR commented Dec 15, 2017

Uh oh!

BridgeAR left a comment

Uh oh!

MylesBorins left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

zkat commented Dec 7, 2017

Checklist

Affected core subsystem(s)

Description of Changes

Changelogs

Uh oh!

MylesBorins commented Dec 8, 2017

Uh oh!

evanlucas left a comment

Choose a reason for hiding this comment

Uh oh!

fishcharlie commented Dec 12, 2017

Uh oh!

BridgeAR commented Dec 12, 2017

Uh oh!

zkat commented Dec 12, 2017

Uh oh!

richardlau commented Dec 12, 2017

Uh oh!

zkat commented Dec 12, 2017

Uh oh!

corvinrok commented Dec 14, 2017

Uh oh!

BridgeAR commented Dec 15, 2017

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

MylesBorins left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants