Conversation
This is an absolute first draft. This method was previously exposed by V8 (since Node v8.0.0) and not implemented in Node directly. Tests coming soon. Refs: nodejs#17128
5229ec0 to
b63a553
Compare
|
If we are implementing these then we should be following the spec as far as the arguments available go. https://console.spec.whatwg.org/#dirxml |
|
In general, I think there's some confusion here around what This means that it is not supposed to parse XML or anything similar. This is one of those methods that's a whole lot more useful in the browser because DOM nodes are just JS objects. If we are implementing this in Node, then it should be very similar to |
|
@apapirovski You make quite a good point, and perhaps I misunderstood the method's purpose indeed. I'll try and rework this as you stated! Thanks! |
|
In fact, as I'm not touching utils anymore, I'm going to close this PR and open a new one I think. Thanks again! |
This is an absolute first draft.
This method was previously exposed by V8 (since Node v8.0.0) and not
implemented in Node directly.
Tests coming soon.
Refs: #17128
Please don't hesitate to leave me an advice. Tests are coming, and doc, but I first want to be sure I'm doing it right, or not bad at least.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
console, util