test: bypass dns for IPv6 net tests#16976
Merged
refack merged 1 commit intonodejs:masterfrom Nov 21, 2017
Merged
Conversation
Contributor
Author
refack
added
dns
joyeecheung
reviewed
Nov 12, 2017
Member
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
IIUC this is safe to do because the integration test of the family option is done in test/internet/test-dns-ipv*.js...
Member
There was a problem hiding this comment.
I don't think we need this anymore if we are mocking lookup? AFAICT the errors are emitted there.
Contributor
Author
There was a problem hiding this comment.
I'll remove and stress test.
Contributor
Author
joyeecheung
approved these changes
Nov 13, 2017
3 tasks
joyeecheung
added
the
author ready
Member
|
Should be ready to land. New CI: https://ci.nodejs.org/job/node-test-pull-request/11594/ |
PR-URL: nodejs#16976 Refs: nodejs#16248 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
refack
force-pushed
the
less-ipv6-dns
branch
from
e071487 to
283b949
Compare
Contributor
Author
|
Thanks. Landed in 283b949 |
refack
removed
the
author ready
Merged
Member
|
@refack mind raising a backport? |
2 tasks
BethGriggs
pushed a commit
to BethGriggs/node
that referenced
this pull request
Jul 10, 2018
PR-URL: nodejs#16976 Refs: nodejs#16248 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #16248
For to test that target
httpsandnetmock out the call todns, but verify all the right parameters are passedChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test,net,https,dns