Merged
Conversation
Contributor
Author
|
/CC @wooorm @nodejs/build |
Contributor
Author
gibfahn
approved these changes
Nov 10, 2017
Member
|
Seems like a reasonable solution to me. |
Contributor
Author
|
I'm just following @zkat's posts, they're the magician behind this. (Can't wait for |
joyeecheung
approved these changes
Nov 11, 2017
gireeshpunathil
approved these changes
Nov 11, 2017
cjihrig
approved these changes
Nov 11, 2017
jasnell
approved these changes
Nov 12, 2017
Member
|
You probably already did this, but just in case: If we have a documented update process for these things, make sure it removes the package-lock.json and replaces it with a new one. I see, for example, that |
2597140 to
61793df
Compare
MylesBorins
pushed a commit
that referenced
this pull request
Dec 11, 2017
by using package-lock.json PR-URL: #16945 Fixes: #16628 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Member
|
Do we want to backport this? I feel like the discussion about what to do with remark hasn't quite finished, so maybe we should hold off. On the other hand we've already backported some of the remark-cli changes to v8.x, so maybe we need to bring this back too. |
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
by using package-lock.json PR-URL: #16945 Fixes: #16628 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 14, 2018
by using package-lock.json PR-URL: #16945 Fixes: #16628 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Aug 16, 2018
by using package-lock.json PR-URL: #16945 Fixes: #16628 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with a hydrated cache running
npm installwhile apackage-lock.jsonis present yields an 80% speedup.Fixes: #16628
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools