Closed
Conversation
nodejs-github-bot
added
i18n-api
jasnell
approved these changes
Nov 12, 2017
tools/icu/README.md
Outdated
Contributor
There was a problem hiding this comment.
Nit: not just Intl.* — it‘s also used for e.g. RegExp Unicode property escapes.
Member
There was a problem hiding this comment.
@mathiasbynens Would just using internationalization functionality instead of Intl functionality sound good to you?
Contributor
There was a problem hiding this comment.
Yeah, that sounds good!
Contributor
|
CI: https://ci.nodejs.org/job/node-test-pull-request-lite/10/ I would like to land this soon so will implement the change suggested by @mathiasbynens myself. It's been sitting around for almost a month now due to that tiny little thing. |
Member
|
New Mini-CI (seemed like the old one failed?): https://ci.nodejs.org/job/node-test-commit-light/148/ |
BridgeAR
added
the
author ready
srl295
force-pushed
the
update-icu-guide
branch
from
56d88de to
2343bd8
Compare
srl295
force-pushed
the
update-icu-guide
branch
from
2343bd8 to
bd36a36
Compare
srl295
force-pushed
the
update-icu-guide
branch
from
bd36a36 to
34cbce9
Compare
srl295
force-pushed
the
update-icu-guide
branch
from
34cbce9 to
07712d1
Compare
2 tasks
Merged
Contributor
|
Does this need to be backported? |
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
- remove TODOs: the one about defaults has been addressed, and the one about testing is a work item that doesn't belong in a doc. - add some background information Fixes: nodejs#7843 PR-URL: nodejs#16939 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
This was referenced Mar 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addressed, and the one about testing is a work
item that doesn't belong in a doc.
Fixes: #7843
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)