[WIP]tools: remove closure_linter to eslint on windows

[yosuke-furukawa]

This is a work in progress.
I found an error on Windows CI. gjslint still exists on vbuild.bat.
BUT, I don't have a Windows environment... So I have not confirmed this yet.
If I got our Jenkins permission, I will run the tests on Windows.

[Fishrock123]

R=@iojs/build?

[rvagg]

when does closure_linter get removed from the tree? is this the last use of it?

also, @yosuke-furukawa has jenkins creds now, as do most other collaborators, it's probably just the newest collaborators that aren't set up now, they're welcome to ping me directly if they're not getting creds quick enough

[silverwind]

I don't think Windows does * expansion in the shell, so instead you need a command line like this:

"%config%\iojs" tools\eslint\bin\eslint.js src lib --reset --quiet

Also, I couldn't get vcbuild jslint to run properly on my windows machine (it just builds and terminates), but that could be an issue on my side.

[silverwind]

Oh, and let's not forget about the internal dir:

"%config%\iojs" tools\eslint\bin\eslint.js src lib lib\internal --reset --quiet

[silverwind]

Nevermind, it seems specifying a directory makes eslint recursive automatically. so src lib is sufficient. I'll open a PR to fix that in the Makefile too.

[jbergstroem]

I don't think you have to quote the command. LGTM after reverting to just specifying directories -- tested on one of the buildslaves (2012).

[silverwind]

@jbergstroem did you test vcbuild jslint or the command directly?

[jbergstroem]

@silverwind I replaced the old lines in vcbuild.bat with above and ran vcbuild.bat x64 nosign jslint.

[silverwind]

Alright, LGTM then.

[yosuke-furukawa]

jslint does not print error like python: can't open file 'tools/closure_linter/closure_linter/gjslint.py': [Errno 2] No such file or directory.
https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/674/nodes=win2012r2/console

I will land this.

[yosuke-furukawa]

Landed. 966acb9

Thank you for review.

[yosuke-furukawa]

@rvagg

when does closure_linter get removed from the tree? is this the last use of it?

Sorry for late response. We have discussed here. #1539

[silverwind]

Minor nit I didn't notice earlier (sorry): path separator should be \ on Windows. It still works with / because of path normalization, but if we want to be fully correct, I'd fix that :)

[rlidwka]

It still works with / because of path normalization, but if we want to be fully correct, I'd fix that :)

Is there any practical reason to use backslashes? I mean if io.js/windows supports forward slashes, it might make sense to use them everywhere for consistency reasons.