lib: setup IPC channel before console#16562
Closed
seishun wants to merge 0 commit intonodejs:masterfrom
seishun:ipc-einval
Closed
lib: setup IPC channel before console#16562seishun wants to merge 0 commit intonodejs:masterfrom seishun:ipc-einval
seishun wants to merge 0 commit intonodejs:masterfrom
seishun:ipc-einval
Conversation
nodejs-github-bot
added
the
lib / src
addaleax
approved these changes
Oct 27, 2017
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
If there is no way to write a test for this, can you add a comment so that nobody accidentally moves this around again?
refack
approved these changes
Oct 27, 2017
Contributor
|
AFAICT a regression test is simple: d:\code\node-master$ set NODE_CHANNEL_FD=0
d:\code\node-master$ node
child_process.js:107
p.open(fd);
^
Error: EINVAL: invalid argument, uv_pipe_open
at Object.exports._forkChild (child_process.js:107:5)
at Object.setupChannel (internal/process.js:244:8)
at startup (bootstrap_node.js:69:16)
at bootstrap_node.js:608:3
d:\code\node-master$ set NODE_CHANNEL_FD=
d:\code\node-master$ |
cjihrig
approved these changes
Oct 28, 2017
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM but a test would be great.
Contributor
Author
refack
approved these changes
Oct 28, 2017
Contributor
There was a problem hiding this comment.
Suggestion:
// make sure `fd[1]` has not been opened for `console`
lib/internal/bootstrap_node.js
Outdated
Contributor
There was a problem hiding this comment.
Suggestion:
// This needs to happen after `_process.setupChannel()`
Contributor
Author
There was a problem hiding this comment.
There's a regression test and git blame, so I don't think it's necessary (or even useful in this form tbh).
addaleax
approved these changes
Oct 29, 2017
Contributor
Author
Contributor
|
Still LGTM, thanks. |
Contributor
Author
|
The failure seems unrelated. |
jasnell
approved these changes
Oct 29, 2017
seishun
added a commit
that referenced
this pull request
Oct 29, 2017
Initializing IOCP on the same fd twice can fail on Windows. Consequently, if the IPC channel uses fd 1 or 2 and the console is setup first, writing to the IPC channel will fail. PR-URL: #16562 Fixes: #16141 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
Author
|
Landed in 403ccb6. |
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
Initializing IOCP on the same fd twice can fail on Windows. Consequently, if the IPC channel uses fd 1 or 2 and the console is setup first, writing to the IPC channel will fail. PR-URL: #16562 Fixes: #16141 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
Initializing IOCP on the same fd twice can fail on Windows. Consequently, if the IPC channel uses fd 1 or 2 and the console is setup first, writing to the IPC channel will fail. PR-URL: #16562 Fixes: #16141 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 31, 2017
Initializing IOCP on the same fd twice can fail on Windows. Consequently, if the IPC channel uses fd 1 or 2 and the console is setup first, writing to the IPC channel will fail. PR-URL: #16562 Fixes: #16141 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
Initializing IOCP on the same fd twice can fail on Windows. Consequently, if the IPC channel uses fd 1 or 2 and the console is setup first, writing to the IPC channel will fail. PR-URL: nodejs/node#16562 Fixes: nodejs/node#16141 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
Initializing IOCP on the same fd twice can fail on Windows. Consequently, if the IPC channel uses fd 1 or 2 and the console is setup first, writing to the IPC channel will fail. PR-URL: nodejs/node#16562 Fixes: nodejs/node#16141 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
|
Should this be backported to |
Contributor
Author
|
No need to backport since #16141 isn't an issue on v6.x AFAIK. |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
Initializing IOCP on the same fd twice can fail on Windows. Consequently, if the IPC channel uses fd 1 or 2 and the console is setup first, writing to the IPC channel will fail. PR-URL: nodejs/node#16562 Fixes: nodejs/node#16141 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initializing IOCP on the same fd twice can fail on Windows.
Consequently, if the IPC channel uses fd 1 or 2 and the console is setup
first, writing to the IPC channel will fail.
Fixes: #16141
Will add a test if there are no objections to this approach.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
lib