Conversation
Member
Author
Contributor
|
For bookkeeping purposes, this should close #1397. |
Contributor
|
#862 should also be closable by this.. still looking through the list for others. |
Member
Contributor
|
#1512 also I think. Those four issues seem to be the ones this fixes. |
Closed
bnoordhuis
pushed a commit
that referenced
this pull request
May 6, 2015
Member
|
LGTM and the CI is happy. Landed in 04cc03b, thanks Saúl. |
Member
|
I might need some help crafting a Notable Changes entry about this, I wasn't aware that we had so much resting on this, can someone in here take a stab at a summary of what this buys us? Also, great work @saghul, @bnoordhuis and other libuv folk! |
Member
Maybe @indutny can comment on #1512. I kind of zoned out after the first few messages. |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 19, 2015
Fixes: nodejs#1397 Fixes: nodejs#1512 Fixes: nodejs#1621 Fixes: nodejs#862 PR-URL: nodejs#1646 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R=@bnoordhuis, @indutny
/cc @Fishrock123