http2: do not allow socket manipulation#16330
Closed
apapirovski wants to merge 2 commits intonodejs:masterfrom
Closed
http2: do not allow socket manipulation#16330apapirovski wants to merge 2 commits intonodejs:masterfrom
apapirovski wants to merge 2 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
lib / src
jasnell
reviewed
Oct 20, 2017
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
This is great. Thank you. Will sign off once the docs are added
lib/internal/http2/core.js
Outdated
Member
There was a problem hiding this comment.
Appalling once and on should be ok. The rest of these look good
Member
There was a problem hiding this comment.
Stupid autocorrect. Allowing not appalling
Because of the specific serialization and processing requirements of HTTP/2, sockets should not be directly manipulated. This forbids any interactions with destroy, emit, end, once, on, pause, read, resume and write methods of the socket. It also redirects setTimeout to session instead of socket. Fixes: nodejs#16252 Refs: nodejs#16211
apapirovski
force-pushed
the
patch-http2-core-socket
branch
from
e9cc55f to
5bdb794
Compare
Contributor
Author
|
ping @jasnell — would like to get this in 9.0.0 if the doc & other changes look good (first commit is unchanged, just rebased so had to force push) |
jasnell
approved these changes
Oct 24, 2017
Contributor
Author
Contributor
Author
|
One failure unrelated, going ahead with the merge. |
Contributor
Author
|
Landed in 73533a1 |
apapirovski
added a commit
that referenced
this pull request
Oct 25, 2017
Because of the specific serialization and processing requirements of HTTP/2, sockets should not be directly manipulated. This forbids any interactions with destroy, emit, end, pause, read, resume and write methods of the socket. It also redirects setTimeout to session instead of socket. PR-URL: #16330 Fixes: #16252 Refs: #16211 Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
Because of the specific serialization and processing requirements of HTTP/2, sockets should not be directly manipulated. This forbids any interactions with destroy, emit, end, pause, read, resume and write methods of the socket. It also redirects setTimeout to session instead of socket. PR-URL: nodejs/node#16330 Fixes: nodejs/node#16252 Refs: nodejs/node#16211 Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
Because of the specific serialization and processing requirements of HTTP/2, sockets should not be directly manipulated. This forbids any interactions with destroy, emit, end, pause, read, resume and write methods of the socket. It also redirects setTimeout to session instead of socket. PR-URL: #16330 Fixes: #16252 Refs: #16211 Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
Because of the specific serialization and processing requirements of HTTP/2, sockets should not be directly manipulated. This forbids any interactions with destroy, emit, end, pause, read, resume and write methods of the socket. It also redirects setTimeout to session instead of socket. PR-URL: #16330 Fixes: #16252 Refs: #16211 Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 31, 2017
Because of the specific serialization and processing requirements of HTTP/2, sockets should not be directly manipulated. This forbids any interactions with destroy, emit, end, pause, read, resume and write methods of the socket. It also redirects setTimeout to session instead of socket. PR-URL: #16330 Fixes: #16252 Refs: #16211 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 31, 2017
This LTS release comes with 87 commits. This includes 30 that are
updates to lib/ or src/, 20 that are test related, 13 that are doc
related, 19 which are build / tools related, and 4 commits which are
updates to dependencies.
Notable Changes:
* doc:
- add Gibson Fahnestock to Release team (Gibson Fahnestock)
#16620
* deps:
- update npm to 5.5.1 (Myles Borins)
#16509
* http2:
- The exposed http2 socket is no longer manipulatable
(Anatoli Papirovski)
#16330
* module:
- support custom paths to require.resolve() (cjihrig)
#16397
* util:
- util.TextEncoder and util.TextDecoder are no longer experimental.
There will no longer be a warning when they are used
(James M Snell)
#15743
PR-URL: #16630
gibfahn
added a commit
that referenced
this pull request
Oct 31, 2017
This LTS release comes with 87 commits. This includes 30 that are
updates to lib/ or src/, 20 that are test related, 13 that are doc
related, 19 which are build / tools related, and 4 commits which are
updates to dependencies.
Notable Changes:
* doc:
- add Gibson Fahnestock to Release team (Gibson Fahnestock)
#16620
* deps:
- update npm to 5.5.1 (Myles Borins)
#16509
* http2:
- The exposed http2 socket is no longer manipulatable
(Anatoli Papirovski)
#16330
* module:
- support custom paths to require.resolve() (cjihrig)
#16397
* util:
- util.TextEncoder and util.TextDecoder are no longer experimental.
There will no longer be a warning when they are used
(James M Snell)
#15743
PR-URL: #16630
gibfahn
added a commit
that referenced
this pull request
Oct 31, 2017
This LTS release comes with 87 commits. This includes 30 that are
updates to lib/ or src/, 20 that are test related, 13 that are doc
related, 19 which are build / tools related, and 4 commits which are
updates to dependencies.
Notable Changes:
* doc:
- add Gibson Fahnestock to Release team (Gibson Fahnestock)
#16620
* deps:
- update npm to 5.5.1 (Myles Borins)
#16509
* http2:
- The exposed http2 socket is no longer manipulatable
(Anatoli Papirovski)
#16330
* module:
- support custom paths to require.resolve() (cjihrig)
#16397
* util:
- util.TextEncoder and util.TextDecoder are no longer experimental.
There will no longer be a warning when they are used
(James M Snell)
#15743
PR-URL: #16630
jasnell
pushed a commit
that referenced
this pull request
Oct 31, 2017
This LTS release comes with 87 commits. This includes 30 that are
updates to lib/ or src/, 20 that are test related, 13 that are doc
related, 19 which are build / tools related, and 4 commits which are
updates to dependencies.
Notable Changes:
* doc:
- add Gibson Fahnestock to Release team (Gibson Fahnestock)
#16620
* deps:
- update npm to 5.5.1 (Myles Borins)
#16509
* http2:
- The exposed http2 socket is no longer manipulatable
(Anatoli Papirovski)
#16330
* module:
- support custom paths to require.resolve() (cjihrig)
#16397
* util:
- util.TextEncoder and util.TextDecoder are no longer experimental.
There will no longer be a warning when they are used
(James M Snell)
#15743
PR-URL: #16630
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
This LTS release comes with 87 commits. This includes 30 that are
updates to lib/ or src/, 20 that are test related, 13 that are doc
related, 19 which are build / tools related, and 4 commits which are
updates to dependencies.
Notable Changes:
* doc:
- add Gibson Fahnestock to Release team (Gibson Fahnestock)
nodejs/node#16620
* deps:
- update npm to 5.5.1 (Myles Borins)
nodejs/node#16509
* http2:
- The exposed http2 socket is no longer manipulatable
(Anatoli Papirovski)
nodejs/node#16330
* module:
- support custom paths to require.resolve() (cjihrig)
nodejs/node#16397
* util:
- util.TextEncoder and util.TextDecoder are no longer experimental.
There will no longer be a warning when they are used
(James M Snell)
nodejs/node#15743
PR-URL: nodejs/node#16630
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
This LTS release comes with 87 commits. This includes 30 that are
updates to lib/ or src/, 20 that are test related, 13 that are doc
related, 19 which are build / tools related, and 4 commits which are
updates to dependencies.
Notable Changes:
* doc:
- add Gibson Fahnestock to Release team (Gibson Fahnestock)
nodejs/node#16620
* deps:
- update npm to 5.5.1 (Myles Borins)
nodejs/node#16509
* http2:
- The exposed http2 socket is no longer manipulatable
(Anatoli Papirovski)
nodejs/node#16330
* module:
- support custom paths to require.resolve() (cjihrig)
nodejs/node#16397
* util:
- util.TextEncoder and util.TextDecoder are no longer experimental.
There will no longer be a warning when they are used
(James M Snell)
nodejs/node#15743
PR-URL: nodejs/node#16630
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
Because of the specific serialization and processing requirements of HTTP/2, sockets should not be directly manipulated. This forbids any interactions with destroy, emit, end, pause, read, resume and write methods of the socket. It also redirects setTimeout to session instead of socket. PR-URL: nodejs/node#16330 Fixes: nodejs/node#16252 Refs: nodejs/node#16211 Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
This LTS release comes with 87 commits. This includes 30 that are
updates to lib/ or src/, 20 that are test related, 13 that are doc
related, 19 which are build / tools related, and 4 commits which are
updates to dependencies.
Notable Changes:
* doc:
- add Gibson Fahnestock to Release team (Gibson Fahnestock)
nodejs/node#16620
* deps:
- update npm to 5.5.1 (Myles Borins)
nodejs/node#16509
* http2:
- The exposed http2 socket is no longer manipulatable
(Anatoli Papirovski)
nodejs/node#16330
* module:
- support custom paths to require.resolve() (cjihrig)
nodejs/node#16397
* util:
- util.TextEncoder and util.TextDecoder are no longer experimental.
There will no longer be a warning when they are used
(James M Snell)
nodejs/node#15743
PR-URL: nodejs/node#16630
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #16252. I still need to update the documentation and potentially the error message but figured the review could get started.
We might need to discuss how much stuff we forbid on the socket, it's possible it's too restrictive currently or perhaps still too permissive.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2, test