docs: fix: correctly use public key instead of private key#16038
Closed
pomerantsev wants to merge 1 commit intonodejs:masterfrom
Closed
docs: fix: correctly use public key instead of private key#16038pomerantsev wants to merge 1 commit intonodejs:masterfrom
public key instead of private key#16038pomerantsev wants to merge 1 commit intonodejs:masterfrom
Conversation
Fixes nodejs#13633 Although, as docs mention, private keys can be used instead of public keys, I presume that these parameter explanations should be corrected.
nodejs-github-bot
added
crypto
BridgeAR
approved these changes
Oct 6, 2017
Trott
added
the
code-and-learn
addaleax
approved these changes
Oct 7, 2017
Member
|
Landed in 1b358f1 |
Member
|
|
Contributor
|
This is actually incorrect. Public keys don't have passphrases - this property is only needed if you provide an encrypted private key instead of a public key. |
Member
Member
|
No, I think @seishun is right, this patch is not entirely correct. The change is partially correct, but the passphrase is only needed if a private key is passed instead of a public key. |
Member
Merged
Member
|
Oops, my bad, this is unrelated to the mentioned backport PR, it was just a very similar fix (but that one was hopefully correct). |
Member
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Oct 8, 2017
Since `crypto.publicDecrypt()` and `crypto.publicEncrypt()` accept both public and private keys, make it clear that the `passphrase` option only applies to private keys. Refs: nodejs#16038
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
Although, as docs mention, private keys can be used instead of public keys, I presume that these parameter explanations should be corrected. Fixes: nodejs/node#13633 PR-URL: nodejs/node#16038 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Contributor
|
This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported |
jasnell
pushed a commit
that referenced
this pull request
Oct 18, 2017
Since `crypto.publicDecrypt()` and `crypto.publicEncrypt()` accept both public and private keys, make it clear that the `passphrase` option only applies to private keys. PR-URL: #16087 Ref: #16038 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
Since `crypto.publicDecrypt()` and `crypto.publicEncrypt()` accept both public and private keys, make it clear that the `passphrase` option only applies to private keys. PR-URL: #16087 Ref: #16038 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
Since `crypto.publicDecrypt()` and `crypto.publicEncrypt()` accept both public and private keys, make it clear that the `passphrase` option only applies to private keys. PR-URL: nodejs/node#16087 Ref: nodejs/node#16038 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
Since `crypto.publicDecrypt()` and `crypto.publicEncrypt()` accept both public and private keys, make it clear that the `passphrase` option only applies to private keys. PR-URL: nodejs/node#16087 Ref: nodejs/node#16038 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13633
Although, as docs mention, private keys can be used instead of
public keys, I presume that these parameter explanations
should be corrected.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes