test: in test-tls-connect replace fixturedir w fixture mod

[cassandradanger]

fixes: code & learn 10.6 vancouver 1st task

Checklist

• [X ] make -j4 test (UNIX), or vcbuild test (Windows) passes
• [ X] tests and/or benchmarks are included
• documentation is changed or added
• [X ] commit message follows commit guidelines

Affected core subsystem(s)

• updated test/test-tls-connect

[pawelgolda]

This will fail tests as you cannot path.join fixtures. Moreover, this could be using method fixtures.readSync instead of fs.readFileSync.

[jasnell]

Hello @cassandradanger! Thank you for participating in the code and learn! This does have a few additional edits that will be necessary... specifically, the change here should be:

const cert = fixtures.readSync('test_cert.pem');
const key = fixtures.readSync('test_key.pem');

[jasnell]

Here it should be:

const cert = fixtures.readSync('test_cert.pem');
const key = fixtures.readSync('test_key.pem');

[gireeshpunathil]

soft ping @cassandradanger

[BridgeAR]

Ping @cassandradanger

[apapirovski]

Hi @cassandradanger, would you like to follow up on this and make the requested changes so it can land in Node? Let me know if there's any clarifications needed. Thanks for helping us improve Node!

[Trott]

I went ahead and pushed the changes suggested by @jasnell. Hope that was OK.

This should be good to go. PTAL

CI: https://ci.nodejs.org/job/node-test-pull-request/11033/

[joyeecheung]

LGTM. I wonder why aren't those files in fixtures/keys?

[Trott]

Landed in a70ef36.

Thanks for the contribution! 🎉

[tniessen]

@cassandradanger The email address you used to commit the changes does not match your GitHub email address, so the commit cannot be associated with your account. Please add the email address you used to commit the changes to your account in the GitHub settings if you would like this change to be linked to your profile.