doc: fix unassigned deprecation code#15741
Closed
jasnell wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Forgot to assign the deprecation code when landing 1f8d527
cjihrig
approved these changes
Oct 2, 2017
refack
approved these changes
Oct 2, 2017
refack
referenced
this pull request
Oct 2, 2017
Replace the internal `path._makeLong()` with a public `path.toLongUNCPath()` method. Add documentation. PR-URL: #14956 Ref: standard-things/esm#66 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
tniessen
approved these changes
Oct 2, 2017
Member
Author
|
Landed in 1261b94 |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 4, 2017
Forgot to assign the deprecation code when landing 1f8d527e94ad97e7db14d18406fe0e12983358cb PR-URL: nodejs/node#15741 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forgot to assign the deprecation code when landing 1f8d527
this really shouldn't need to wait the 48 hours to land.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
docs