module: fix regression in main ESM loading

[targos]

When the requested module cannot be resolved to a file, loading should
always fail, regardless of wether ESM is enabled or not.

Fixes: #15732

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[jasnell]

assert.fail() here instead of the throw?

[cjihrig]

LGTM with a comment/suggestion.

[cjihrig]

Could the test be simplified by using execFileSync() instead?

[gibfahn]

But isn't using async-await cooler 😁 ?

[targos]

Haha I totally forgot there was a sync version! I was only thinking about how complicated it would be with callbacks xD.

[targos]

There is something weird. I changed the test to use execFileSync and it fails as expected with node 8.6.0. However, I cannot make it work with current master because the error I'm catching does not have a stdout or stderr property.

[targos]

I think #13601 might have gone too far and removed properties that are supposed to be there according to the docs.

[targos]

/cc @mscdex

[gibfahn]

Confirmed that 448c4c6 is the commit that introduces the change, using script provided by @targos:

t.js

const { execFileSync } = require('child_process');

try {
  execFileSync(process.argv[0], ['xxx'], {stdio: 'ignore'});
} catch (e) {
  console.log(Object.keys(e));
}

Commit before 448c4c6

$ ./node t.js
[ 'error',
  'file',
  'args',
  'options',
  'envPairs',
  'stderr',
  'stdout',
  'pid',
  'output',
  'signal',
  'status' ]

Commit 448c4c6

$ ./node t.js
[ 'status', 'signal' ]

[targos]

Quick fix:

diff --git a/lib/child_process.js b/lib/child_process.js
index a3cdadd..f041a86 100644
--- a/lib/child_process.js
+++ b/lib/child_process.js
@@ -566,8 +566,8 @@ function checkExecSyncError(ret, args, cmd) {
     err = new Error(msg);
   }
   if (err) {
-    err.status = ret.status < 0 ? errname(ret.status) : ret.status;
-    err.signal = ret.signal;
+    Object.assign(err, ret);
   }
   return err;
 }

[cjihrig]

@targos do you plan to work on this, or will it be included in #16147?

[targos]

I will see when I'm back from vacation (Oct 23)

[targos]

I'm going to close this one because #16147 takes care of it.