Merged
Conversation
mscdex
added
the
meta
Member
|
LGTM |
Contributor
Author
|
fwiw I'd like to sort out #1559 first just in the case that we create further issues. |
Contributor
|
When these commits are cherry-picked, it'd probably be good to add metadata to the messages along the lines of |
Contributor
Author
|
@chrisdickinson original shas are easy-ish to find via the original PR. I'm more concerned about these port PRs actually. It's been hard to find PRs where colin merged in commits from node in the past, for example. (Although we could do both, doesn't need the full original SHA.) |
Contributor
Author
|
Going to land with this metadata, and create a second backport pr. |
tls.connect(options) with no options.host should accept a certificate with CN: 'localhost'. Fix Error: Hostname/IP doesn't match certificate's altnames: "Host: undefined. is not cert's CN: localhost" 'localhost' is not added directly to defaults because that is not always desired (for example, when using options.socket) PR-URL: nodejs#1493 PORT-PR-URL: nodejs#1560 PORT-FROM: v2.x / a7d7463 Fixes: nodejs#1489 Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com> Reviewed-By: Roman Reiss <me@silverwind.io>
PR-URL: nodejs#1530 PORT-PR-URL: nodejs#1560 PORT-FROM: v2.x / 5472139 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
parallel tests still not working on most build slaves PR-URL: nodejs#1544 PORT-PR-URL: nodejs#1560 PORT-FROM: v2.x / 2a3c8c1 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Some modules are monkey-patching Buffer.isEncoding, so without this they cannot do that. Fixes: nodejs#1547 PR-URL: nodejs#1548 PORT-PR-URL: nodejs#1560 PORT-FROM: v2.x / 0fa6c4a Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: nodejs#1553 PORT-PR-URL: nodejs#1560 PORT-FROM: v2.x / f9c681c Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Based on tests running on original Raspberry Pi PR-URL: nodejs#1554 PORT-PR-URL: nodejs#1560 PORT-FROM: v2.x / f9b226c Reviewed-By: Roman Reiss <me@silverwind.io>
Fishrock123
force-pushed
the
backport-to-v1.x
branch
from
fe08db9 to
32a6dbc
Compare
This was referenced May 14, 2015
Member
|
What's the benefit of adding branch in port-from? Edit: gotcha. Full history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just fixes. Especially to the tests and how the CI runs are now run, this will make v1.x CI runs viable again.
Also, due to the
string_decoderthing, might be worthwhile to do a 1.8.2 in the coming weeks.