Skip to content

test: increase coverage for internal/errors.js#15044

Closed
starkwang wants to merge 1 commit intonodejs:masterfrom
starkwang:test-internal-errors-improve
Closed

test: increase coverage for internal/errors.js#15044
starkwang wants to merge 1 commit intonodejs:masterfrom
starkwang:test-internal-errors-improve

Conversation

@starkwang
Copy link
Contributor

@starkwang starkwang commented Aug 26, 2017 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 26, 2017
@mscdex mscdex added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Aug 26, 2017
@hiroppy
Copy link
Member

hiroppy commented Aug 29, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9864/

@jasnell
Copy link
Member

jasnell commented Aug 29, 2017

Trying again on windows: https://ci.nodejs.org/job/node-test-commit-windows-fanned/11382/

@benjamingr
Copy link
Member

benjamingr commented Aug 30, 2017

@refack @nodejs/build can you take a look at the repeated failure at https://ci.nodejs.org/job/node-test-commit-windows-fanned/11382/

@BridgeAR
Copy link
Member

BridgeAR commented Aug 30, 2017 •
edited
Loading

Landed in 44d4865

@BridgeAR BridgeAR closed this Aug 30, 2017
@refack
Copy link
Contributor

refack commented Aug 30, 2017

@refack @nodejs/build can you take a look at the repeated failure at https://ci.nodejs.org/job/node-test-commit-windows-fanned/11382/

Will do

BridgeAR pushed a commit that referenced this pull request Aug 30, 2017
@starkwang @BridgeAR
test: increase coverage for internal/errors.js
44d4865 
PR-URL: #15044
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@refack
Copy link
Contributor

refack commented Aug 30, 2017

@benjamingr AFAICT I fixed it:
https://ci.nodejs.org/job/node-compile-windows/11452/label=win-vs2017/console (same machine test-rackspace-win2012r2-x64-10)

@jasnell
Copy link
Member

jasnell commented Aug 30, 2017

hmm looks like a build bot failure on windows again. Trying one more time https://ci.nodejs.org/job/node-test-commit-windows-fanned/11404/

@BridgeAR
Copy link
Member

BridgeAR commented Aug 30, 2017

Well instead of 2017 now 2015 is failing.

cjihrig pushed a commit to cjihrig/node that referenced this pull request Aug 31, 2017
@starkwang @cjihrig
test: increase coverage for internal/errors.js
904487f 
PR-URL: nodejs#15044
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 5, 2017
@starkwang @addaleax
test: increase coverage for internal/errors.js
63213c2 
PR-URL: nodejs/node#15044
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins
Copy link
Contributor

MylesBorins commented Sep 10, 2017

The tests are failing on v8.x. Not sure exactly what is going on, but it may have something to do with util.format

AssertionError [ERR_ASSERTION]: 'The "a" argument must be of type not b' === 'The "a" argument must not be of type b'
    at Object.<anonymous> (/Users/mborins/code/node/master/test/parallel/test-internal-errors.js:202:8)
    at Module._compile (module.js:573:30)
    at Object.Module._extensions..js (module.js:584:10)
    at Module.load (module.js:507:32)
    at tryModuleLoad (module.js:470:12)
    at Function.Module._load (module.js:462:3)
    at Function.Module.runMain (module.js:609:10)
    at startup (bootstrap_node.js:194:16)
    at bootstrap_node.js:619:3

@jasnell
Copy link
Member

jasnell commented Sep 20, 2017

I believe this depends on a previous semver-major. Marking don't land on v8.x

@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

+2 more reviewers

@refack refack refack approved these changes

@hiroppy hiroppy hiroppy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

errors Issues and PRs related to JavaScript errors originated in Node.js core. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@starkwang @hiroppy @jasnell @benjamingr @BridgeAR @refack @MylesBorins @addaleax @mscdex @nodejs-github-bot