doc,stream: remove wrong remark on readable.read#15014
Closed
jscissr wants to merge 1 commit intonodejs:masterfrom
Closed
doc,stream: remove wrong remark on readable.read#15014jscissr wants to merge 1 commit intonodejs:masterfrom
jscissr wants to merge 1 commit intonodejs:masterfrom
Conversation
jasnell
reviewed
Aug 24, 2017
test/async-hooks/test-graph.tcp.js
Outdated
Contributor
Author
There was a problem hiding this comment.
I don't know from where this commit appeared.It might be related to the "allow edits from maintainers" option on the pull request. Or maybe this commit was deleted from master, but is still in my branch?
It also affects #15013
Contributor
Author
There was a problem hiding this comment.
This seems to be the reason. I will rebase on master.
mcollina
approved these changes
Aug 24, 2017
Member
mcollina
left a comment
There was a problem hiding this comment.
LGTM without the spurious changes.
The returned chunk is *never* longer than `size`.
Contributor
Author
|
Did a rebase now. |
jasnell
approved these changes
Aug 24, 2017
lpinca
approved these changes
Aug 25, 2017
jasnell
pushed a commit
that referenced
this pull request
Aug 25, 2017
The returned chunk is *never* longer than `size`. PR-URL: #15014 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
Landed in 8987ae8 |
ghost
pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 30, 2017
The returned chunk is *never* longer than `size`. PR-URL: nodejs/node#15014 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ghost
pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 30, 2017
The returned chunk is *never* longer than `size`. PR-URL: nodejs/node#15014 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
The returned chunk is *never* longer than `size`. PR-URL: #15014 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
The returned chunk is *never* longer than `size`. PR-URL: #15014 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 20, 2017
The returned chunk is *never* longer than `size`. PR-URL: #15014 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The returned chunk is never longer than
size, if I read the code correctly. I even tested it:Output:
Even tough the stream has ended, the data returned does not exceed
sizebytes.Checklist
Affected core subsystem(s)
stream