doc: add missing word#14924
Conversation
nodejs-github-bot
added
build
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM!
I don’t think this PR needs to wait the customary 48 hours.
|
There is a typo in the commit message (mising). |
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM. Might be a better word than build to use, especially because the word recurs shortly thereafter. Perhaps binary or executable? Or maybe this?:
If you have Node.js installed already, you can build just the docs with:
All that said, I'm fine with this as it is if there's no desire to make the changes I'm suggesting here.
|
@Trott before I submitted this PR I had |
PR-URL: #14924 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 0914880! I see this was your first contribution! Thank you and welcome! |
It's all good. The most important thing is that the text be improved. If someone wants to come along and improve it even more later, that's great. If not, that's fine too. Thanks for taking the time to open a pull request! 🎉 |
PR-URL: #14924 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #14924 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #14924 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
8 participants
Checklist
Add missing word to documentation.
Affected core subsystem(s)
doc