[backport v6.x] tools: update ESLint to 4.2.0

[Trott]

@MylesBorins Hopefully you can swap this in for 80029b4 and then the rest of the commits that are already on v6.x-staging will unroll over it nicely?

ESLint 4.2.0 contains a fix for a bug that is blocking us from moving to
the non-legacy stricter indentation linting. Update to 4.2.0 to remove
the blocking issue.

PR-URL: #14155
Ref: eslint/eslint#8882
Ref:://github.com/eslint/eslint/pull/8885
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Gibson Fahnestock gibfahn@gmail.com
Reviewed-By: Refael Ackermann refack@gmail.com

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

[aqrln]

Missing " https" in the third line of metadata in the commit message:

Ref:://github.com/eslint/eslint/pull/8885

[Trott]

Thanks, @aqrln! Copy/paste error fixed.

And just in case anyone is noticing all the conflicts: This should apply to 3bd0c7c, not to HEAD of the v6.x-staging branch.

[MylesBorins]

Hey @Trott. What is the difference between this backport and the version I landed?

…

On Aug 16, 2017 7:28 AM, "Rich Trott" ***@***.***> wrote: Thanks, @aqrln <https://github.com/aqrln>! Copy/paste error fixed. And just in case anyone is noticing all the conflicts: This should apply to 3bd0c7c <3bd0c7c>, not to HEAD of the v6.x-staging branch. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#14859 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAecV8p9KwUmFoJXqxoJWYpAd9Ygr1C5ks5sYvyOgaJpZM4O4-Go> .

[Trott]

Hey @Trott. What is the difference between this backport and the version I
landed?

Not sure. Version you landed was a cherry-pick from master, I imagine. For whatever reason, make jslint fails after that gets cherry-picked over to v6.x-staging.

For this, I rewound to the immediately prior commit on v6.x-staging and updated manually to ESLint 4.2.0 and...oh I see I downgraded the markdown plugin linter from 1.0.0-beta.7 to 1.0.0-beta.4. Maybe that was the problem? Maybe the commit you cherry-picked has to land before the commit that updates the markdown plugin linter to 1.0.0-beta.7 (e5ca046)?

[MylesBorins]

landed 1