repl: include folder extensions in autocomplete#14727
Closed
not-an-aardvark wants to merge 0 commit intonodejs:masterfrom
Closed
repl: include folder extensions in autocomplete#14727not-an-aardvark wants to merge 0 commit intonodejs:masterfrom
not-an-aardvark wants to merge 0 commit intonodejs:masterfrom
Conversation
Contributor
Author
hiroppy
approved these changes
Aug 10, 2017
TimothyGu
approved these changes
Aug 10, 2017
tniessen
approved these changes
Aug 10, 2017
aqrln
approved these changes
Aug 10, 2017
cjihrig
approved these changes
Aug 10, 2017
benjamingr
approved these changes
Aug 10, 2017
not-an-aardvark
commented
Aug 10, 2017
lib/repl.js
Outdated
Contributor
Author
There was a problem hiding this comment.
Looking at this again, I'm wondering if this should be moved back into a try-catch to avoid creating an error if the path doesn't exist.
Member
There was a problem hiding this comment.
It would be a race condition that is hart to trigger but as there was a guard for this before I would say it should be kept as it was.
BridgeAR
requested changes
Aug 10, 2017
lib/repl.js
Outdated
Member
There was a problem hiding this comment.
It would be a race condition that is hart to trigger but as there was a guard for this before I would say it should be kept as it was.
lib/repl.js
Outdated
Member
There was a problem hiding this comment.
The try should be moved into the if statement as it is not necessary for non directories.
Contributor
Author
BridgeAR
approved these changes
Aug 11, 2017
lib/repl.js
Outdated
Member
There was a problem hiding this comment.
Nit: you could get rid of one of the isDirectory checks (the churn is there anyway).
if (isDirectory) {
// ...
} else if (exts.includes(ext)) {
// ...
}
Contributor
Author
not-an-aardvark
force-pushed
the
repl-autocomplete-folder-extensions
branch
from
31e2174 to
b646a3d
Compare
not-an-aardvark
added a commit
to not-an-aardvark/node
that referenced
this pull request
Aug 13, 2017
When autocompleting `require` calls, the repl strips .js file extensions from results. However, stripping an extension from a directory results in an error. Update the autocompletion logic to avoid stripping extensions from directories. PR-URL: nodejs#14727 Fixes: nodejs#14726 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Contributor
Author
|
Landed in b646a3d |
addaleax
pushed a commit
that referenced
this pull request
Aug 13, 2017
When autocompleting `require` calls, the repl strips .js file extensions from results. However, stripping an extension from a directory results in an error. Update the autocompletion logic to avoid stripping extensions from directories. PR-URL: #14727 Fixes: #14726 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
repl
When autocompleting
requirecalls, the repl strips .js file extensions from results. However, stripping an extension from a directory results in an error whenrequireis called. Update the autocompletion logic to avoid stripping extensions from directories.Fixes: #14726