test: fix conversion of microseconds in test#14706
test: fix conversion of microseconds in test#14706nickstanish wants to merge 1 commit intonodejs:masterfrom
Conversation
|
Hi, @nickstanish! Welcome, and thanks for the contribution! Small change to the commit message (and I guess this PR title too): The subsystem here is |
|
Pummel tests don't get run in Ci so only the linter results are relevant, but here's a CI run anyway... CI: https://ci.nodejs.org/job/node-test-pull-request/9565/ CI has not been having a good week, but we should be able to get some linter results at least. :-D |
7989ff7 to
d0621a6
Compare
|
thanks @nickstanish !!! LGTM |
|
CI is good (only failure is a known issue unrelated to this). Given the small nature of the change, the low risk (it's a test modification, and easy to revert if it turns out there is an unforeseen problem), and the copious approvals, I'm going to land this now rather than waiting the full 48 hours. |
PR-URL: nodejs#14706 Fixes: nodejs#8728 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
|
Landed in a439cf4. Thanks for the contribution! 🎉 |
Fixes: #8728
Changes the conversion for process cpuUsage test
Checklist
Affected core subsystem(s)
process