test: replace indexOf with includes#14630
Closed
maasencioh wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
nodejs-github-bot
added
async_hooks
cjihrig
approved these changes
Aug 4, 2017
29 tasks
vsemozhetbyt
approved these changes
Aug 4, 2017
Contributor
tniessen
approved these changes
Aug 4, 2017
Member
tniessen
left a comment
tniessen
left a comment
There was a problem hiding this comment.
Thank you for picking this up!
addaleax
approved these changes
Aug 4, 2017
targos
approved these changes
Aug 4, 2017
jasnell
approved these changes
Aug 4, 2017
hiroppy
approved these changes
Aug 5, 2017
TimothyGu
approved these changes
Aug 5, 2017
Contributor
Author
|
@tniessen thank you, to be honest I've never had that many approvals in a PR 😃 |
aqrln
approved these changes
Aug 6, 2017
jasnell
pushed a commit
that referenced
this pull request
Aug 8, 2017
Refs: #12586 PR-URL: #14630 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Member
|
Landed in 9564c20 |
Contributor
Author
|
thank you all, that was really fast! |
addaleax
pushed a commit
that referenced
this pull request
Aug 10, 2017
Refs: #12586 PR-URL: #14630 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed all the tests that the issue #12586 was relevant to
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes