Conversation
addaleax
left a comment
There was a problem hiding this comment.
I don’t know the best way forward either, but I think you can feel free to just re-land these now.
|
I'm pretty sure those starting with "deps:" are not necessary with 6.0. That's why I didnt include them. |
|
I just built |
Adds missing return which fixes debug builds on Windows Fixes: nodejs#13392 Ref: https://codereview.chromium.org/2929993003/ Refs: nodejs#13634 PR-URL: nodejs#14582 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
8730544 to
6afa220
Compare
|
I dropped the @refack did you have a chance to find out if the debug build is working with VS2015? |
Just completed. |
|
Running CI forced to build |
|
(Previus CI seems like it works reasonalby well, I'm assuming the sporadic compilation failures are related to memory shortage) |
|
Windows debug CI compiles (without patch). |
|
Closing as it appears we do not need these commits |
There were three missing patches that were included in #13515 that were missed in #14004
It seems like these were missed because they either
a) Directly touch the V8 system and were not upstreamed
or
b) Were backports that did not follow our backport process
I'm not sure the best process for landing these... please advise
/cc @nodejs/v8