test: add test-fs-read-buffer-to-string-fail as pass and flaky to all…#14472
Closed
Jeyanthinath wants to merge 2 commits intonodejs:v6.x-stagingfrom
Closed
test: add test-fs-read-buffer-to-string-fail as pass and flaky to all…#14472Jeyanthinath wants to merge 2 commits intonodejs:v6.x-stagingfrom
Jeyanthinath wants to merge 2 commits intonodejs:v6.x-stagingfrom
Conversation
Jeyanthinath
force-pushed
the
jeyanthi#14430
branch
from
1840570 to
72e43aa
Compare
jasnell
approved these changes
Jul 25, 2017
refack
approved these changes
Jul 25, 2017
Contributor
Contributor
Is it possible someone force pushed to |
Contributor
|
@sam-github was it intentional? |
Contributor
|
@refack Yes: #14418 (comment) |
Contributor
|
Ok. |
Contributor
Author
|
@refack Sure |
The --redirect-warnings command line argument allows process warnings to be written to a specified file rather than printed to stderr. Also adds an equivalent NODE_REDIRECT_WARNINGS environment variable. If the specified file cannot be opened or written to for any reason, the argument is ignored and the warning is printed to stderr. If the file already exists, it will be appended to. Backport-PR-URL: nodejs#14418 PR-URL: nodejs#10116 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Michal Zasso <targos@protonmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Jeyanthinath
force-pushed
the
jeyanthi#14430
branch
from
72e43aa to
3726641
Compare
Contributor
Author
|
Sorry Guys I have a hard time rebasing , I will repoen a new pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14430 [v6.x] test: investigate test-fs-read-buffer-tostring-fail