test: allow inspector to reopen with same port#14320
Merged
gibfahn merged 1 commit intonodejs:masterfrom Aug 12, 2017
Merged
Conversation
gibfahn
added
inspector
benjamingr
approved these changes
Jul 17, 2017
tniessen
approved these changes
Jul 17, 2017
Member
tniessen
left a comment
tniessen
left a comment
There was a problem hiding this comment.
I wonder why the assertion was there before. LGTM assuming that the inspector correctly closes the socket.
lpinca
approved these changes
Jul 17, 2017
jasnell
approved these changes
Jul 17, 2017
cjihrig
approved these changes
Jul 17, 2017
Member
Author
That's tested above by |
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-commit/11724/ CI was green except for macOS, which failed with: which is #14747 |
Test checks that if you open the inspector with '0' (pick a random free port), close it, then reopen it, you get a different port. However this isn't necessarily true. PR-URL: nodejs#14320 Fixes: nodejs#14316 Refs: nodejs#14316 (comment) Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn
force-pushed
the
flake-inspector-open
branch
from
23836a6 to
8780e1d
Compare
addaleax
pushed a commit
that referenced
this pull request
Aug 12, 2017
Test checks that if you open the inspector with '0' (pick a random free port), close it, then reopen it, you get a different port. However this isn't necessarily true. PR-URL: #14320 Fixes: #14316 Refs: #14316 (comment) Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
Author
|
Adding |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test checks that if you open the inspector with '0' (pick a random free
port), close it, then reopen it, you get a different port. However this
isn't necessarily true.
Fixes: #14316
Refs: #14316 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, inspector