test: replace string concatenation with template literals#14280
test: replace string concatenation with template literals#14280jankjn wants to merge 1 commit intonodejs:masterfrom
Conversation
Trott
added
the
code-and-learn
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Maybe this instead?:
const fixturesDir = common.fixturesDir;
const content = require(
`${fixturesDir}/json-with-directory-name-module/module-stub/one/two/three.js`
);
TimothyGu
added
code-and-learn
|
Yeah, this looks much better, I've changed it @Trott |
There was a problem hiding this comment.
This is Ok.
But it would be much better to use path.join instead, see #14272 (comment)
You could even do it with multiple parts
const filePath = path.join(
common.fixturesDir,
'json-with-directory-name-module',
'module-stub',
'one-trailing-slash',
'two',
'three.js'
);There was a problem hiding this comment.
Thanks for suggestion, I like the path.join way
|
Assuming that CI is healed from back pressure (how to verify that? I see only 5 jobs in the pipeline) issued a fresh one: https://ci.nodejs.org/job/node-test-pull-request/9183/ Also, is it possible to |
@gireeshpunathil It's subjective. Things get ugly in the CI interface after 15 jobs are in the pipeline, so I would take that as an absolute hard limit. But even at 10 jobs, it means delaying other people who are trying to use CI by potentially hours. So for small changes (like most I'd also note that the 5-job recommendation above is taking into account that our CI is much slower right now than is usually is (because Node.js startup is much slower now than it usually is due to the temporary disabling of V8 snapshots in Node.js). In more typical times, I'd probably put that suggested limit to more like 8 or 10 jobs. |
@gireeshpunathil I don't think so, but maybe someone in @nodejs/build knows otherwise... |
No. The closest you can get is the Rebuild plugin (nodejs/build#672). |
Trott
changed the title
PR-URL: nodejs#14280 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
|
Landed in 8ddb725 |
PR-URL: #14280 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #14280 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #14280 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #14280 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #14280 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #14280 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
13 participants
from Workshop Code + Learn
replace string concatenation in test/parallel/test-require-extensions-same-filename-as-dir.js with template literals.