test: improve error message for stream writable change default encoding test#14264
Closed
fraserxu wants to merge 1 commit intonodejs:masterfrom
Closed
test: improve error message for stream writable change default encoding test#14264fraserxu wants to merge 1 commit intonodejs:masterfrom
fraserxu wants to merge 1 commit intonodejs:masterfrom
Conversation
fraserxu
changed the title
Trott
added
the
code-and-learn
fraserxu
force-pushed
the
test-stream-writeable-change-default-encoding
branch
from
6654c71 to
d37a55a
Compare
Member
TimothyGu
added
code-and-learn
Member
|
I don't think this needs to wait 72 hours, but a second approval would be good. Anyone? |
bengl
approved these changes
Jul 16, 2017
Member
|
Landed in 35398af. Thanks for the contribution! 🎉 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 16, 2017
In test-stream-writable-change-default-encoding, use a regular expression to match the complete error message. PR-URL: nodejs#14264 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
In test-stream-writable-change-default-encoding, use a regular expression to match the complete error message. PR-URL: #14264 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
Fishrock123
pushed a commit
that referenced
this pull request
Jul 19, 2017
In test-stream-writable-change-default-encoding, use a regular expression to match the complete error message. PR-URL: #14264 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 16, 2017
In test-stream-writable-change-default-encoding, use a regular expression to match the complete error message. PR-URL: #14264 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Aug 16, 2017
In test-stream-writable-change-default-encoding, use a regular expression to match the complete error message. PR-URL: #14264 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 5, 2017
In test-stream-writable-change-default-encoding, use a regular expression to match the complete error message. PR-URL: #14264 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
This was referenced Sep 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test