Closed
Conversation
nodejs-github-bot
added
doc
vsemozhetbyt
approved these changes
Jul 16, 2017
Contributor
|
Thank you! Linter CI: https://ci.nodejs.org/job/node-test-linter/10517/ (is green) |
gibfahn
approved these changes
Jul 16, 2017
cjihrig
reviewed
Jul 16, 2017
doc/api/errors.md
Outdated
| For example: | ||
|
|
||
| ```js | ||
| assert.equal(1, 2); |
Contributor
There was a problem hiding this comment.
I'd recommend using strictEqual() here to help set readers up for success :-)
cjihrig
approved these changes
Jul 16, 2017
tniessen
approved these changes
Jul 16, 2017
| ## Class: AssertionError | ||
|
|
||
| A subclass of `Error` that indicates the failure of an assertion. Such errors | ||
| commonly indicate inequality of actual and expected parameters. |
Member
There was a problem hiding this comment.
IMO this could as well be "values" instead of "parameters", still LGTM.
jasnell
approved these changes
Jul 17, 2017
XadillaX
pushed a commit
that referenced
this pull request
Aug 10, 2017
Fixes: #12274 PR-URL: #14261 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
Contributor
|
Landed in 4796fbc. Congratulations and thanks for your first contribution! Before: After: |
addaleax
pushed a commit
that referenced
this pull request
Aug 10, 2017
Fixes: #12274 PR-URL: #14261 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)