test: temporarily disable MultipleEnvironmentsPerIsolate

[refack]

Ref: #14206

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

Affected core subsystem(s)

test,cctest

[refack]

/cc @nodejs/testing @mhdawson @jBarz
Let's fast track this band-aid.

Also I've set a calendar reminder to revisit on Wednesday 7/14

[Trott]

I don't suppose there's any already-existing and easy way to disable it in some environments only?

[refack]

I don't suppose there's any already-existing and easy way to disable it in some environments only?

Maybe some #ifndef voodoo, but I'm not going there 🙌

1. We have 4 people keeping an eye on this
2. AFAICT it's the only place we create two Envs so even if we forget this and it rots, it's gonna be a while until we encounter this scenario in real code.

[Trott]

LGTM if CI is green.

In principle, I'm on board with fast-tracking this, but I'd want an additional 👍 on that from someone who has a better understanding of our C++ code.

[refack]

CI: https://ci.nodejs.org/job/node-test-commit/11123/
@Trott you wanted this to land in 24 hours for the code-and-learn, right?

[Trott]

@Trott you wanted this to land in 24 hours for the code-and-learn, right?

That would be great! If not, though, I can probably remove plinux from the build infra for the duration of Code + Learn, so it's not critical that it happen.

[refack]

@nodejs/collaborators we would like another opinion on this, thank you...

[gibfahn]

I think as long as #14206 stays open (and we keep investigating it) then doing this is fine.

Unfortunately I don't "have a better understanding of our cpp code". But I don't think there's a problem with doing this.

[gibfahn]

That would be great! If not, though, I can probably remove plinux from the build infra for the duration of Code + Learn, so it's not critical that it happen.

I'd much rather do this than remove a platform from CI.

[Trott]

Landed in 95ab966

[MylesBorins]

as we are not having issue with cc tests on v6.x I think we can pass on this for now.

[refack]

Agreed.
(underlining bug was solved, so this was reverted anyway)